Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unified cdn for logos #235

Open
ciuffagianluca opened this issue Jul 20, 2023 · 0 comments
Open

Use unified cdn for logos #235

ciuffagianluca opened this issue Jul 20, 2023 · 0 comments

Comments

@ciuffagianluca
Copy link
Contributor

Use same repo (possibly CDN) for all logos about psp, card brand, pagopa and all others kind of logo

          > > > In this point the old logo image is used to show it in the header

import pagopaLogo from "../../assets/images/pagopa-logo.svg";

but the new logo image have a different name

This is another ref, to the image dir, while we are replacing the one in logos dir

Are we sure that we do not need to update the image in the assets/images folder as well ?

These are different resources that belong to different domains. I agree with you that it should be better to have single logo repo and single logo ref, but changing it could lead to undesired frontend issue. Moreover, unify logos is out of the scope of this PR. This could be a good point to mark as tech debt and report in a github issue. What do you think?

Originally posted by @ciuffagianluca in #233 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant