You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is another ref, to the image dir, while we are replacing the one in logos dir
Are we sure that we do not need to update the image in the assets/images folder as well ?
These are different resources that belong to different domains. I agree with you that it should be better to have single logo repo and single logo ref, but changing it could lead to undesired frontend issue. Moreover, unify logos is out of the scope of this PR. This could be a good point to mark as tech debt and report in a github issue. What do you think?
Use same repo (possibly CDN) for all logos about psp, card brand, pagopa and all others kind of logo
These are different resources that belong to different domains. I agree with you that it should be better to have single logo repo and single logo ref, but changing it could lead to undesired frontend issue. Moreover, unify logos is out of the scope of this PR. This could be a good point to mark as tech debt and report in a github issue. What do you think?
Originally posted by @ciuffagianluca in #233 (comment)
The text was updated successfully, but these errors were encountered: