Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIDM-35] fix: Optimize transfer iban update query #291

Merged
merged 13 commits into from
Feb 7, 2025
Merged

[PIDM-35] fix: Optimize transfer iban update query #291

merged 13 commits into from
Feb 7, 2025

Conversation

svariant
Copy link
Collaborator

@svariant svariant commented Feb 6, 2025 •
edited
Loading

List of Changes

  • Rewritten Transfer IBAN update query to optimize performances
  • Added limit of 1000 updates per call
  • Refactored code
  • Update tests
  • Update openapi

Motivation and Context

PIDM-35

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the patch label Feb 6, 2025
@svariant svariant requested a review from a team as a code owner February 6, 2025 15:58
@svariant svariant marked this pull request as draft February 6, 2025 16:02
@svariant svariant marked this pull request as ready for review February 6, 2025 17:22
cap-ang
cap-ang requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, but I suggest some adjustments

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cap-ang cap-ang self-requested a review February 7, 2025 11:08
cap-ang
cap-ang approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@cap-ang cap-ang merged commit d501a0a into main Feb 7, 2025
14 of 16 checks passed
@cap-ang cap-ang deleted the PIDM-35-optimize-transfer-iban-update branch February 7, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cap-ang cap-ang cap-ang approved these changes

@jacopocarlini jacopocarlini Awaiting requested review from jacopocarlini

Assignees

@svariant svariant

Labels
patch size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svariant @cap-ang @pagopa-platform-gps-bot @pagopa-github-bot