From 61f5f1c9725159fd7773cdc53beea361d751d813 Mon Sep 17 00:00:00 2001 From: gianmarcoplutino Date: Fri, 22 Nov 2024 17:16:00 +0100 Subject: [PATCH] fix: undo Sonar vulnerability --- .../service/ContractServiceDefault.java | 25 +++++++------------ 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/apps/onboarding-functions/src/main/java/it/pagopa/selfcare/onboarding/service/ContractServiceDefault.java b/apps/onboarding-functions/src/main/java/it/pagopa/selfcare/onboarding/service/ContractServiceDefault.java index 782a38adc..ad0565a70 100644 --- a/apps/onboarding-functions/src/main/java/it/pagopa/selfcare/onboarding/service/ContractServiceDefault.java +++ b/apps/onboarding-functions/src/main/java/it/pagopa/selfcare/onboarding/service/ContractServiceDefault.java @@ -284,28 +284,21 @@ private File createPdfFileContract( private File createPdfFileAttachment(String attachmentTemplatePath, Onboarding onboarding) throws IOException { - String timestamp = LocalDateTime.now().format(DateTimeFormatter.ofPattern("yyyyMMddHHmmss")); - String uniqueId = UUID.randomUUID().toString(); - String filePrefix = "allegato_interoperabilita_" + timestamp + "_" + uniqueId; - - // Usa una directory temporanea dedicata - Path tempDir = Files.createTempDirectory("secureTempDir"); - - // Crea il file temporaneo nella directory sicura - Path attachmentPdfFile = Files.createTempFile(tempDir, filePrefix, ".pdf"); + final String builder = + LocalDateTime.now().format(DateTimeFormatter.ofPattern("yyyyMMddHHmmss")) + + "_" + + UUID.randomUUID() + + "_allegato_interoperabilita."; - // Leggi il contenuto del template del contratto + // Read the content of the contract template file. String attachmentTemplateText = azureBlobClient.getFileAsText(attachmentTemplatePath); - - // Prepara i dati comuni per il documento PDF + // Create a temporary PDF file to store the contract. + Path attachmentPdfFile = Files.createTempFile(builder, ".pdf"); + // Prepare common data for the contract document. Map data = setUpAttachmentData(onboarding); log.debug("data Map for PDF: {}", data); - - // Scrivi i dati nel file PDF fillPDFAsFile(attachmentPdfFile, attachmentTemplateText, data); - - // Restituisci il file temporaneo return attachmentPdfFile.toFile(); }