Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ConnectionConfig to be provided a custom metric registry for the Hikari data source #5227

Open
mccheah opened this issue Jan 26, 2021 · 0 comments

Comments

@mccheah
Copy link

mccheah commented Jan 26, 2021

Currently, ConnectionConfig#getHikariConfig bootstraps a MetricsRegistry via SharedMetricRegistries#getOrCreate (see .here However, some users may have their own MetricRegistry that they wish to bootstrap into the config. We can use HikariConfig#setMetricRegistry after the ConnectionConfig has returned the HikariConfig, but in doing so we leave the redundant MetricRegistry hanging in SharedMetricRegistries. We should provide a means for ConnectionConfig to be provided the MetricRegistry directly when creating the HikariConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant