From 23e52d0820e610659a5943a8edd0d02824aeb055 Mon Sep 17 00:00:00 2001
From: Gregory Douglas <gdouglas@palantir.com>
Date: Mon, 13 Jan 2025 09:33:04 -0500
Subject: [PATCH 1/2] Ignore deprecated ReactDOM methods in test code

---
 packages/core/test/context-menu/contextMenuTests.tsx        | 1 +
 packages/core/test/forms/textAreaTests.tsx                  | 1 +
 packages/core/test/slider/multiSliderTests.tsx              | 1 +
 packages/core/test/toast/overlayToasterTests.tsx            | 1 +
 packages/core/test/toast/toasterTests.tsx                   | 1 +
 packages/core/test/tree/treeTests.tsx                       | 1 +
 packages/datetime/test/components/dateRangeInputTests.tsx   | 1 +
 packages/datetime/test/components/timePickerTests.tsx       | 2 ++
 packages/datetime2/test/components/dateRangeInput3Tests.tsx | 1 +
 packages/table/test/common/internal/scrollUtilsTests.tsx    | 1 +
 packages/table/test/harness.ts                              | 2 ++
 packages/table/test/locatorTests.tsx                        | 2 ++
 packages/table/test/quadrants/tableQuadrantStackTests.tsx   | 2 ++
 packages/table/test/table2Tests.tsx                         | 2 ++
 14 files changed, 19 insertions(+)

diff --git a/packages/core/test/context-menu/contextMenuTests.tsx b/packages/core/test/context-menu/contextMenuTests.tsx
index 4ab27ff12e..03c73e9b4b 100644
--- a/packages/core/test/context-menu/contextMenuTests.tsx
+++ b/packages/core/test/context-menu/contextMenuTests.tsx
@@ -61,6 +61,7 @@ describe("ContextMenu", () => {
         document.body.appendChild(containerElement);
     });
     afterEach(() => {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(containerElement!);
         containerElement!.remove();
     });
diff --git a/packages/core/test/forms/textAreaTests.tsx b/packages/core/test/forms/textAreaTests.tsx
index 851a923103..e933eb315b 100644
--- a/packages/core/test/forms/textAreaTests.tsx
+++ b/packages/core/test/forms/textAreaTests.tsx
@@ -31,6 +31,7 @@ describe("<TextArea>", () => {
     });
 
     afterEach(() => {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(containerElement!);
         containerElement!.remove();
     });
diff --git a/packages/core/test/slider/multiSliderTests.tsx b/packages/core/test/slider/multiSliderTests.tsx
index d2d17316b8..d733d9ab8f 100644
--- a/packages/core/test/slider/multiSliderTests.tsx
+++ b/packages/core/test/slider/multiSliderTests.tsx
@@ -47,6 +47,7 @@ describe("<MultiSlider>", () => {
     });
 
     afterEach(() => {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
         testsContainerElement.remove();
     });
diff --git a/packages/core/test/toast/overlayToasterTests.tsx b/packages/core/test/toast/overlayToasterTests.tsx
index 9c5eff8718..3f45abc666 100644
--- a/packages/core/test/toast/overlayToasterTests.tsx
+++ b/packages/core/test/toast/overlayToasterTests.tsx
@@ -61,6 +61,7 @@ function unmountReact16Toaster(containerElement: HTMLElement) {
     if (toasterRenderRoot == null) {
         throw new Error("No elements were found under Toaster container.");
     }
+    // eslint-disable-next-line deprecation/deprecation
     ReactDOM.unmountComponentAtNode(toasterRenderRoot);
 }
 
diff --git a/packages/core/test/toast/toasterTests.tsx b/packages/core/test/toast/toasterTests.tsx
index c66db953ef..632d6fd860 100644
--- a/packages/core/test/toast/toasterTests.tsx
+++ b/packages/core/test/toast/toasterTests.tsx
@@ -27,6 +27,7 @@ describe("Toaster", () => {
     });
 
     afterEach(() => {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
     });
 
diff --git a/packages/core/test/tree/treeTests.tsx b/packages/core/test/tree/treeTests.tsx
index 42f5d33530..626303ecba 100644
--- a/packages/core/test/tree/treeTests.tsx
+++ b/packages/core/test/tree/treeTests.tsx
@@ -32,6 +32,7 @@ describe("<Tree>", () => {
     });
 
     afterEach(() => {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
     });
 
diff --git a/packages/datetime/test/components/dateRangeInputTests.tsx b/packages/datetime/test/components/dateRangeInputTests.tsx
index 607e19f3a9..99d77bc2a8 100644
--- a/packages/datetime/test/components/dateRangeInputTests.tsx
+++ b/packages/datetime/test/components/dateRangeInputTests.tsx
@@ -75,6 +75,7 @@ describe("<DateRangeInput>", () => {
     });
     afterEach(() => {
         if (containerElement !== undefined) {
+            // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(containerElement);
             containerElement.remove();
         }
diff --git a/packages/datetime/test/components/timePickerTests.tsx b/packages/datetime/test/components/timePickerTests.tsx
index 18efc91be1..4561f9b9ce 100644
--- a/packages/datetime/test/components/timePickerTests.tsx
+++ b/packages/datetime/test/components/timePickerTests.tsx
@@ -43,6 +43,7 @@ describe("<TimePicker>", () => {
     });
 
     afterEach(() => {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
     });
 
@@ -747,6 +748,7 @@ describe("<TimePicker>", () => {
     }
 
     function renderTimePicker(props?: Partial<TimePickerProps>) {
+        // eslint-disable-next-line deprecation/deprecation
         timePicker = ReactDOM.render<TimePickerProps>(
             <TimePicker onChange={onTimePickerChange} {...props} />,
             testsContainerElement,
diff --git a/packages/datetime2/test/components/dateRangeInput3Tests.tsx b/packages/datetime2/test/components/dateRangeInput3Tests.tsx
index 25ccd2ffa9..22eec0ae2f 100644
--- a/packages/datetime2/test/components/dateRangeInput3Tests.tsx
+++ b/packages/datetime2/test/components/dateRangeInput3Tests.tsx
@@ -88,6 +88,7 @@ describe("<DateRangeInput3>", () => {
 
     afterEach(() => {
         if (containerElement !== undefined) {
+            // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(containerElement);
             containerElement.remove();
         }
diff --git a/packages/table/test/common/internal/scrollUtilsTests.tsx b/packages/table/test/common/internal/scrollUtilsTests.tsx
index 7db55445fd..c7ffe0fa53 100644
--- a/packages/table/test/common/internal/scrollUtilsTests.tsx
+++ b/packages/table/test/common/internal/scrollUtilsTests.tsx
@@ -339,6 +339,7 @@ describe("scrollUtils", () => {
 
         function mountElementsWithContentSize(contentWidth: number, contentHeight: number) {
             // HACKHACK: `as unknown as HTMLElement` cast is sketchy
+            // eslint-disable-next-line deprecation/deprecation
             return ReactDOM.render<React.HTMLProps<HTMLDivElement>>(
                 <div style={parentStyle}>
                     <div style={{ ...baseStyles, width: contentWidth, height: contentHeight }} />
diff --git a/packages/table/test/harness.ts b/packages/table/test/harness.ts
index 304e83f440..d3dc8ecb30 100644
--- a/packages/table/test/harness.ts
+++ b/packages/table/test/harness.ts
@@ -215,11 +215,13 @@ export class ReactHarness {
 
     public mount(component: React.ReactElement<any>) {
         // wrap in a root provider to avoid console warnings
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.render(React.createElement(BlueprintProvider, { children: component }), this.container);
         return new ElementHarness(this.container);
     }
 
     public unmount() {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(this.container);
     }
 
diff --git a/packages/table/test/locatorTests.tsx b/packages/table/test/locatorTests.tsx
index 8ef6d1c93f..dd042ae678 100644
--- a/packages/table/test/locatorTests.tsx
+++ b/packages/table/test/locatorTests.tsx
@@ -55,6 +55,7 @@ describe("Locator", () => {
         // ".body" will be the scrollable region.
         containerElement = document.createElement("div");
         document.body.appendChild(containerElement);
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.render(
             <div className="table-wrapper" style={style}>
                 <div className="body" style={style}>
@@ -75,6 +76,7 @@ describe("Locator", () => {
     });
 
     afterEach(() => {
+        // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(containerElement);
     });
 
diff --git a/packages/table/test/quadrants/tableQuadrantStackTests.tsx b/packages/table/test/quadrants/tableQuadrantStackTests.tsx
index bab2e50ee7..6ff4abe37f 100644
--- a/packages/table/test/quadrants/tableQuadrantStackTests.tsx
+++ b/packages/table/test/quadrants/tableQuadrantStackTests.tsx
@@ -559,6 +559,7 @@ describe("TableQuadrantStack", () => {
         });
 
         afterEach(() => {
+            // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(container);
             onScroll.resetHistory();
         });
@@ -715,6 +716,7 @@ describe("TableQuadrantStack", () => {
     function renderIntoDom(element: React.JSX.Element) {
         const containerElement = document.createElement("div");
         document.body.appendChild(containerElement);
+        // eslint-disable-next-line deprecation/deprecation
         const component = ReactDOM.render<any>(element, containerElement);
         return {
             component: component as TableQuadrantStack,
diff --git a/packages/table/test/table2Tests.tsx b/packages/table/test/table2Tests.tsx
index 7cc4323ab6..b4ffd9975c 100644
--- a/packages/table/test/table2Tests.tsx
+++ b/packages/table/test/table2Tests.tsx
@@ -61,6 +61,7 @@ describe("<Table2>", function (this) {
     afterEach(() => {
         harness.unmount();
         if (containerElement !== undefined) {
+            // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(containerElement);
             containerElement.remove();
         }
@@ -1498,6 +1499,7 @@ describe("<Table2>", function (this) {
             // get native DOM nodes
             const tableNode = table.getDOMNode();
             const tableBodySelector = `.${Classes.TABLE_BODY_VIRTUAL_CLIENT}`;
+            // eslint-disable-next-line deprecation/deprecation
             const tableBodyNode = ReactDOM.findDOMNode(tableNode.querySelector(tableBodySelector));
 
             // trigger a drag-selection starting at the center of the activation cell

From d529f56fe650510272b3df397fcb755934383435 Mon Sep 17 00:00:00 2001
From: Gregory Douglas <gdouglas@palantir.com>
Date: Tue, 14 Jan 2025 14:31:43 -0500
Subject: [PATCH 2/2] Add comments referencing issue

See: https://github.com/palantir/blueprint/issues/7167
---
 packages/core/test/context-menu/contextMenuTests.tsx        | 1 +
 packages/core/test/forms/textAreaTests.tsx                  | 1 +
 packages/core/test/slider/multiSliderTests.tsx              | 1 +
 packages/core/test/toast/overlayToasterTests.tsx            | 1 +
 packages/core/test/toast/toasterTests.tsx                   | 1 +
 packages/core/test/tree/treeTests.tsx                       | 1 +
 packages/datetime/test/components/dateRangeInputTests.tsx   | 1 +
 packages/datetime/test/components/timePickerTests.tsx       | 2 ++
 packages/datetime2/test/components/dateRangeInput3Tests.tsx | 1 +
 packages/table/test/common/internal/scrollUtilsTests.tsx    | 1 +
 packages/table/test/harness.ts                              | 2 ++
 packages/table/test/locatorTests.tsx                        | 2 ++
 packages/table/test/quadrants/tableQuadrantStackTests.tsx   | 2 ++
 packages/table/test/table2Tests.tsx                         | 2 ++
 14 files changed, 19 insertions(+)

diff --git a/packages/core/test/context-menu/contextMenuTests.tsx b/packages/core/test/context-menu/contextMenuTests.tsx
index 03c73e9b4b..a363c37902 100644
--- a/packages/core/test/context-menu/contextMenuTests.tsx
+++ b/packages/core/test/context-menu/contextMenuTests.tsx
@@ -61,6 +61,7 @@ describe("ContextMenu", () => {
         document.body.appendChild(containerElement);
     });
     afterEach(() => {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(containerElement!);
         containerElement!.remove();
diff --git a/packages/core/test/forms/textAreaTests.tsx b/packages/core/test/forms/textAreaTests.tsx
index e933eb315b..2963e6fd5e 100644
--- a/packages/core/test/forms/textAreaTests.tsx
+++ b/packages/core/test/forms/textAreaTests.tsx
@@ -31,6 +31,7 @@ describe("<TextArea>", () => {
     });
 
     afterEach(() => {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(containerElement!);
         containerElement!.remove();
diff --git a/packages/core/test/slider/multiSliderTests.tsx b/packages/core/test/slider/multiSliderTests.tsx
index d733d9ab8f..8f29c628cc 100644
--- a/packages/core/test/slider/multiSliderTests.tsx
+++ b/packages/core/test/slider/multiSliderTests.tsx
@@ -47,6 +47,7 @@ describe("<MultiSlider>", () => {
     });
 
     afterEach(() => {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
         testsContainerElement.remove();
diff --git a/packages/core/test/toast/overlayToasterTests.tsx b/packages/core/test/toast/overlayToasterTests.tsx
index 3f45abc666..f14fa4f312 100644
--- a/packages/core/test/toast/overlayToasterTests.tsx
+++ b/packages/core/test/toast/overlayToasterTests.tsx
@@ -61,6 +61,7 @@ function unmountReact16Toaster(containerElement: HTMLElement) {
     if (toasterRenderRoot == null) {
         throw new Error("No elements were found under Toaster container.");
     }
+    // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
     // eslint-disable-next-line deprecation/deprecation
     ReactDOM.unmountComponentAtNode(toasterRenderRoot);
 }
diff --git a/packages/core/test/toast/toasterTests.tsx b/packages/core/test/toast/toasterTests.tsx
index 632d6fd860..83f99ce8d4 100644
--- a/packages/core/test/toast/toasterTests.tsx
+++ b/packages/core/test/toast/toasterTests.tsx
@@ -27,6 +27,7 @@ describe("Toaster", () => {
     });
 
     afterEach(() => {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
     });
diff --git a/packages/core/test/tree/treeTests.tsx b/packages/core/test/tree/treeTests.tsx
index 626303ecba..3e478795db 100644
--- a/packages/core/test/tree/treeTests.tsx
+++ b/packages/core/test/tree/treeTests.tsx
@@ -32,6 +32,7 @@ describe("<Tree>", () => {
     });
 
     afterEach(() => {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
     });
diff --git a/packages/datetime/test/components/dateRangeInputTests.tsx b/packages/datetime/test/components/dateRangeInputTests.tsx
index 99d77bc2a8..cb9f953de1 100644
--- a/packages/datetime/test/components/dateRangeInputTests.tsx
+++ b/packages/datetime/test/components/dateRangeInputTests.tsx
@@ -75,6 +75,7 @@ describe("<DateRangeInput>", () => {
     });
     afterEach(() => {
         if (containerElement !== undefined) {
+            // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
             // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(containerElement);
             containerElement.remove();
diff --git a/packages/datetime/test/components/timePickerTests.tsx b/packages/datetime/test/components/timePickerTests.tsx
index 4561f9b9ce..55510e1186 100644
--- a/packages/datetime/test/components/timePickerTests.tsx
+++ b/packages/datetime/test/components/timePickerTests.tsx
@@ -43,6 +43,7 @@ describe("<TimePicker>", () => {
     });
 
     afterEach(() => {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(testsContainerElement);
     });
@@ -748,6 +749,7 @@ describe("<TimePicker>", () => {
     }
 
     function renderTimePicker(props?: Partial<TimePickerProps>) {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         timePicker = ReactDOM.render<TimePickerProps>(
             <TimePicker onChange={onTimePickerChange} {...props} />,
diff --git a/packages/datetime2/test/components/dateRangeInput3Tests.tsx b/packages/datetime2/test/components/dateRangeInput3Tests.tsx
index 22eec0ae2f..f2c0288d8f 100644
--- a/packages/datetime2/test/components/dateRangeInput3Tests.tsx
+++ b/packages/datetime2/test/components/dateRangeInput3Tests.tsx
@@ -88,6 +88,7 @@ describe("<DateRangeInput3>", () => {
 
     afterEach(() => {
         if (containerElement !== undefined) {
+            // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
             // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(containerElement);
             containerElement.remove();
diff --git a/packages/table/test/common/internal/scrollUtilsTests.tsx b/packages/table/test/common/internal/scrollUtilsTests.tsx
index c7ffe0fa53..de2c61ad5a 100644
--- a/packages/table/test/common/internal/scrollUtilsTests.tsx
+++ b/packages/table/test/common/internal/scrollUtilsTests.tsx
@@ -339,6 +339,7 @@ describe("scrollUtils", () => {
 
         function mountElementsWithContentSize(contentWidth: number, contentHeight: number) {
             // HACKHACK: `as unknown as HTMLElement` cast is sketchy
+            // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
             // eslint-disable-next-line deprecation/deprecation
             return ReactDOM.render<React.HTMLProps<HTMLDivElement>>(
                 <div style={parentStyle}>
diff --git a/packages/table/test/harness.ts b/packages/table/test/harness.ts
index d3dc8ecb30..62f0d6d5c8 100644
--- a/packages/table/test/harness.ts
+++ b/packages/table/test/harness.ts
@@ -215,12 +215,14 @@ export class ReactHarness {
 
     public mount(component: React.ReactElement<any>) {
         // wrap in a root provider to avoid console warnings
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.render(React.createElement(BlueprintProvider, { children: component }), this.container);
         return new ElementHarness(this.container);
     }
 
     public unmount() {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(this.container);
     }
diff --git a/packages/table/test/locatorTests.tsx b/packages/table/test/locatorTests.tsx
index dd042ae678..ad6bb44cc3 100644
--- a/packages/table/test/locatorTests.tsx
+++ b/packages/table/test/locatorTests.tsx
@@ -55,6 +55,7 @@ describe("Locator", () => {
         // ".body" will be the scrollable region.
         containerElement = document.createElement("div");
         document.body.appendChild(containerElement);
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.render(
             <div className="table-wrapper" style={style}>
@@ -76,6 +77,7 @@ describe("Locator", () => {
     });
 
     afterEach(() => {
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         ReactDOM.unmountComponentAtNode(containerElement);
     });
diff --git a/packages/table/test/quadrants/tableQuadrantStackTests.tsx b/packages/table/test/quadrants/tableQuadrantStackTests.tsx
index 6ff4abe37f..b42b977044 100644
--- a/packages/table/test/quadrants/tableQuadrantStackTests.tsx
+++ b/packages/table/test/quadrants/tableQuadrantStackTests.tsx
@@ -559,6 +559,7 @@ describe("TableQuadrantStack", () => {
         });
 
         afterEach(() => {
+            // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
             // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(container);
             onScroll.resetHistory();
@@ -716,6 +717,7 @@ describe("TableQuadrantStack", () => {
     function renderIntoDom(element: React.JSX.Element) {
         const containerElement = document.createElement("div");
         document.body.appendChild(containerElement);
+        // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
         // eslint-disable-next-line deprecation/deprecation
         const component = ReactDOM.render<any>(element, containerElement);
         return {
diff --git a/packages/table/test/table2Tests.tsx b/packages/table/test/table2Tests.tsx
index b4ffd9975c..71091d2e30 100644
--- a/packages/table/test/table2Tests.tsx
+++ b/packages/table/test/table2Tests.tsx
@@ -61,6 +61,7 @@ describe("<Table2>", function (this) {
     afterEach(() => {
         harness.unmount();
         if (containerElement !== undefined) {
+            // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
             // eslint-disable-next-line deprecation/deprecation
             ReactDOM.unmountComponentAtNode(containerElement);
             containerElement.remove();
@@ -1499,6 +1500,7 @@ describe("<Table2>", function (this) {
             // get native DOM nodes
             const tableNode = table.getDOMNode();
             const tableBodySelector = `.${Classes.TABLE_BODY_VIRTUAL_CLIENT}`;
+            // TODO(React 18): Replace deprecated ReactDOM methods. See: https://github.com/palantir/blueprint/issues/7167
             // eslint-disable-next-line deprecation/deprecation
             const tableBodyNode = ReactDOM.findDOMNode(tableNode.querySelector(tableBodySelector));