Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix errors in pandas.Series.argmax #32010

Closed

Conversation

farhanreynaldo
Copy link
Contributor

@farhanreynaldo farhanreynaldo commented Feb 15, 2020

output of python scripts/validate_docstrings.py pandas.Series.argmax:

################################################################################
################################## Validation ##################################
################################################################################

@ShaharNaveh
Copy link
Member

Isn't this a duplicate of #31999 ?

@farhanreynaldo
Copy link
Contributor Author

farhanreynaldo commented Feb 15, 2020

Isn't this a duplicate of #31999 ?

I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue.

@ShaharNaveh
Copy link
Member

Isn't this a duplicate of #31999 ?

I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue.

I think what happen was is that you ran git checkout from the branch you were working on, and you forgot to commit the rest of the changes.

@farhanreynaldo
Copy link
Contributor Author

farhanreynaldo commented Feb 15, 2020

Isn't this a duplicate of #31999 ?

I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue.

I think what happen was is that you ran git checkout from the branch you were working on, and you forgot to commit the rest of the changes.

Oh I see. Thank you for letting me know about this. Anything I should do regarding this PR duplication?

@ShaharNaveh
Copy link
Member

Isn't this a duplicate of #31999 ?

I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue.

I think what happen was is that you ran git checkout from the branch you were working on, and you forgot to commit the rest of the changes.

Oh I see. Thank you for let me know this. Anything I should do regarding the PR duplication?

The way I see it, for this PR you can either close it or making the changes to initially intended to do.


Either way thank you for working on this!

@farhanreynaldo farhanreynaldo deleted the argmax-series-doc-2 branch February 15, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants