-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to inject custom CSS files #78
Comments
Thanks for offering your help, much appreciated! Indeed, currently the only way to add a css file is to add html: I think there are several things we can do to improve the situation:
I think that for your usecase, and with the current state of the tool, 2. is the better option. Would you agree to implement it? I can provide guidance if needed! Some other comments:
|
I think supporting both 2 and 3 would be the best way to do it. With having the CLI option, it makes it really easy to include the same CSS file(s) for all presentations. This would be good for something like a theme. Whereas supporting something in the frontmatter could also be beneficial for something that may not need to be included in every presentation, such as highlighting for a specific programming language, or even minor tweaks for a specific presentation. If you are okay with this idea, I think I will start with the CLI option. You also mentioned that this could break your idea of having a completely self contained presentation. This does not necessarily need to be the case. We could specify these CSS files, read them and append the content to the current styling that gets placed in the file itself. There are tradeoffs in doing this, especially for things like highlightjs languages. CDNs make it much easier to cache the content and may be faster at serving the assets than your configured web server. We could also support something like an With that said, I am more than happy to follow your vision on this one. You created this wonderful project after all. |
Yes, that would be perfect! I had a look at the current state of the compiler's code. It would need a bit of clean up :) Sorry about that! Let me know if you need any assistance (there is a The entry point to the CLI code is in the Actually, there is already an option that is quite close to what you suggest: the
If you work toward this, there is no need to do everything in one go! We can improve the situation little by little. And again, tell me how I can improve the contributing experience on this codebase! |
The current theme documentation says that I need to manually edit the generated HTML file in order to add my own CSS to the presentation. In order to have slipshow used with automated deployments, it would be great to have an option that would allow me to specify one or more CSS files that can be added to the final document.
I would be more than happy to implement this if this is something you would like to see.
The text was updated successfully, but these errors were encountered: