Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Set instead? #1

Open
jimmywarting opened this issue Aug 7, 2020 · 0 comments
Open

Use Set instead? #1

jimmywarting opened this issue Aug 7, 2020 · 0 comments

Comments

@jimmywarting
Copy link

- const unique = require('array-unique');


    const start = async () => {
-       const listOfIds = unique(Array.from(matchAll(bigstring, /#(\d+)/g).toArray(), m => +m));
+       const listOfIds = new Set(matchAll(bigstring, /#(\d+)/g).toArray(), m => +m);
      
-       if (listOfIds.length == 0) return;
+       if (!listOfIds.size) return;
    
        let cards = [];
    
        for (item of exitLists) {
            const newCards = await getCardsOfList(apiKey, apiToken, item);
            cards = [...cards, ...newCards];
        }
        
        cards
-           .filter(card => listOfIds.includes(card.idShort))
+           .filter(card => listOfIds.has(card.idShort))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant