Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminus site deploy should exit with a non-zero status if deploy fails #1410

Open
bwood opened this issue Nov 30, 2016 · 0 comments
Open

terminus site deploy should exit with a non-zero status if deploy fails #1410

bwood opened this issue Nov 30, 2016 · 0 comments

Comments

@bwood
Copy link
Contributor

bwood commented Nov 30, 2016

Version

0.13.3

Expected behavior

terminus site deploy should exit with a non-zero status if deploy fails.

Actual behavior

Here are two snippets from a script which execs terminus site deploy and then checks the exit status. In these two cases the exit status was 0, but the log level was "error".

terminus site deploy --site=upgrade-testing-0110-diversity-ob-dl-02 --env=live --cc --updatedb --note="Deployed by klu via /usr/local/bin/istdrupal-updates-apply" --format=json
date: 2016-11-17 01:28:08
level: ERROR
message: cURL error 7: Failed to connect to terminus.pantheon.io port 443: Connection refused (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)
terminus site hostnames list --site=optometry-ob --env=live
Would you like to deploy code from Test to live?  (y/n): y
terminus site deploy --site=optometry-ob --env=live --cc --updatedb --note="Deployed by annagaz via /usr/local/bin/istdrupal-updates-apply" --format=json
date: 2016-11-18 22:08:53
level: ERROR
message: Successfully queued converge_appserver_binding

Steps to reproduce the behavior

Apologies, but I couldn't find a way to reproduce this. I tried creating a TCP error, but got a different message.

Perhaps the timestamps, site names and messages will be useful in tracking down these conditions. If not, I understand. Just thought it might be worth reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants