Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this extension maintained? It does not work with at least pants>=2.17 #51

Open
telmop opened this issue Oct 31, 2023 · 2 comments
Open

Comments

@telmop
Copy link

telmop commented Oct 31, 2023

I recently started using pants v2. I tried using this extension to load some of the code and it doesn't even detect the codebase.

Looking into the code of the plugin, this is happening because this line is looking for a directory called pants, which doesn't exist. It also runs the binary directly (./pants instead of using the one in the path). The widgets don't seem to be working, hiding the error messages.

I cloned it locally and changed the code to get it to build, but still wasn't able to import it yet. However, it seems achievable with a few hours of work.

My question is: was this code abandoned by pants, or should I expect an update some time soon?

@VidakM
Copy link

VidakM commented Dec 10, 2024

It also seems not to be supporting Python 3.11+.

@telmop
Copy link
Author

telmop commented Dec 10, 2024

The plugin does not work at all, but if anyone wants to run jupyter notebooks on their codebase, you can use the build rule below:

pex_binary(
    name="notebook-name",
    dependencies=[
        # Whatever packages you want to import in your notebook.
    ],
    script="jupyter-lab",
    # This is important, otherwise you'll get all kinds of errors.
    execution_mode="venv",
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants