Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: useMemo/useCallback/etc #31

Open
transmissions11 opened this issue Apr 1, 2023 · 1 comment
Open

perf: useMemo/useCallback/etc #31

transmissions11 opened this issue Apr 1, 2023 · 1 comment

Comments

@transmissions11
Copy link
Member

There's currently a lot of areas of the code where callbacks and objects could be memoized but are not. Some help here would be appreciated.

Only thing to note is the fact that nodes and edges (which are both objects) are at the core of everything makes things a little difficult I believe — as we'd need to do a deepequals check in some places which might end up being even more expensive?

@transmissions11
Copy link
Member Author

ideally we have some evidence that these changes actually improve performance and aren't just adding more complexity, as useCallback/useMemo do add some overhead if used incorrectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant