Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: Determine maximum payload size #334

Open
lexnv opened this issue Feb 27, 2025 · 0 comments
Open

identify: Determine maximum payload size #334

lexnv opened this issue Feb 27, 2025 · 0 comments
Labels
priority: low Nice-to-have improvements, optimizations, or future considerations todo Extracted from code todos

Comments

@lexnv
Copy link
Collaborator

lexnv commented Feb 27, 2025

At the moment, the max payload size is hardcoded to 4k. Investigate if this should be changed.

litep2p/src/protocol/libp2p/identify.rs

Lines 58 to 60 in e0b7118

/// Size for `/ipfs/ping/1.0.0` payloads.
// TODO: what is the max size?
const IDENTIFY_PAYLOAD_SIZE: usize = 4096;

@lexnv lexnv added priority: low Nice-to-have improvements, optimizations, or future considerations todo Extracted from code todos labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low Nice-to-have improvements, optimizations, or future considerations todo Extracted from code todos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lexnv