Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kad: PutRecordSuccess and AddProvidedSuccess are not emitted #336

Open
lexnv opened this issue Feb 27, 2025 · 0 comments
Open

kad: PutRecordSuccess and AddProvidedSuccess are not emitted #336

lexnv opened this issue Feb 27, 2025 · 0 comments
Labels
priority: low Nice-to-have improvements, optimizations, or future considerations todo Extracted from code todos

Comments

@lexnv
Copy link
Collaborator

lexnv commented Feb 27, 2025

litep2p/src/protocol/libp2p/kademlia/handle.rs

Lines 226 to 234 in e0b7118

/// `PUT_VALUE` query succeeded.
// TODO: this is never emitted. Implement + add `AddProviderSuccess`.
PutRecordSuccess {
/// Query ID.
query_id: QueryId,
/// Record key.
key: RecordKey,
},

@lexnv lexnv added priority: low Nice-to-have improvements, optimizations, or future considerations todo Extracted from code todos labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low Nice-to-have improvements, optimizations, or future considerations todo Extracted from code todos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lexnv