Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notification/tests: Check test state and increase code coverage #340

Open
lexnv opened this issue Feb 27, 2025 · 0 comments
Open

notification/tests: Check test state and increase code coverage #340

lexnv opened this issue Feb 27, 2025 · 0 comments
Labels
priority: medium Important but not urgent tasks that should be addressed after high-priority issues todo Extracted from code todos

Comments

@lexnv
Copy link
Collaborator

lexnv commented Feb 27, 2025 •
edited
Loading

Increase the code coverage for the notification substream validation testing, and ensure the notification state is checked.

Part of accept_fails_due_to_closed_substream test:

litep2p/src/protocol/notification/tests/substream_validation.rs

Line 332 in e0b7118

// TODO: check state

@lexnv lexnv added medium Requires some knowledge of the codebase todo Extracted from code todos priority: low Nice-to-have improvements, optimizations, or future considerations priority: medium Important but not urgent tasks that should be addressed after high-priority issues and removed medium Requires some knowledge of the codebase priority: low Nice-to-have improvements, optimizations, or future considerations labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium Important but not urgent tasks that should be addressed after high-priority issues todo Extracted from code todos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lexnv