From 193cb5f8f93f1c1c20a38e87c7e6c0fe65a61096 Mon Sep 17 00:00:00 2001 From: Oliver Tale-Yazdi Date: Wed, 7 Aug 2024 22:27:31 +0200 Subject: [PATCH 1/6] [CI] Test README example Somehow the command from the README does not build for me, going to put in the CI to see if it reproduces. --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 027620c..6ad3524 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,6 +41,11 @@ jobs: run: cargo build timeout-minutes: 90 + # Building single packages can cause it to fail, and since this is mentioned in the README as example + # so we should check that it acually works: + - name: Build the node + run: cargo build --package parachain-template-node --release + - name: Run clippy run: | SKIP_WASM_BUILD=1 cargo clippy --all-targets --locked --workspace --quiet From 4f7bb3b66965ae8d2b49ab155bc14c49d8c9198c Mon Sep 17 00:00:00 2001 From: Oliver Tale-Yazdi Date: Wed, 7 Aug 2024 22:28:21 +0200 Subject: [PATCH 2/6] Update ci.yml --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6ad3524..c8a4dc6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,8 +41,7 @@ jobs: run: cargo build timeout-minutes: 90 - # Building single packages can cause it to fail, and since this is mentioned in the README as example - # so we should check that it acually works: + # This is mentioned as example in the README: - name: Build the node run: cargo build --package parachain-template-node --release From 121d8d7af7b4b5b53e8e4a151a0f2098fa115505 Mon Sep 17 00:00:00 2001 From: Oliver Tale-Yazdi Date: Wed, 7 Aug 2024 23:44:23 +0200 Subject: [PATCH 3/6] Fix node config --- node/Cargo.toml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/node/Cargo.toml b/node/Cargo.toml index d044707..570cd6c 100644 --- a/node/Cargo.toml +++ b/node/Cargo.toml @@ -112,7 +112,12 @@ substrate-build-script-utils.workspace = true substrate-build-script-utils.default-features = true [features] -default = [] +default = ["std"] +std = [ + "parachain-template-runtime/std", + "log/std", + "xcm/std" +] runtime-benchmarks = [ "cumulus-primitives-core/runtime-benchmarks", "frame-benchmarking-cli/runtime-benchmarks", From 2b5ef29ce2bbe481ae7e4c5edd489923dd07acf9 Mon Sep 17 00:00:00 2001 From: Przemek Rzad Date: Thu, 8 Aug 2024 16:55:26 +0200 Subject: [PATCH 4/6] Update ci.yml --- .github/workflows/ci.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b17dd64..2a19db4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -54,10 +54,6 @@ jobs: run: cargo build timeout-minutes: 90 - # This is mentioned as example in the README: - - name: Build the node - run: cargo build --package parachain-template-node --release - - name: Run clippy run: | SKIP_WASM_BUILD=1 cargo clippy --all-targets --locked --workspace --quiet @@ -72,6 +68,13 @@ jobs: run: SKIP_WASM_BUILD=1 cargo doc --workspace --no-deps timeout-minutes: 15 + # This is mentioned as example in the README: + - name: Build the node + run: | + # Save some space from debug builds + rm -rf ./target + cargo build --package parachain-template-node --release + build-docker: runs-on: ubuntu-latest steps: From 50900ab6e18b95248ca9871c1abf811f14225ad2 Mon Sep 17 00:00:00 2001 From: Przemek Rzad Date: Thu, 8 Aug 2024 17:12:54 +0200 Subject: [PATCH 5/6] Update ci.yml --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2a19db4..6b8d56e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -74,6 +74,7 @@ jobs: # Save some space from debug builds rm -rf ./target cargo build --package parachain-template-node --release + timeout-minutes: 90 build-docker: runs-on: ubuntu-latest From 370bd285b61bfb038076834af8b97b8216f8cfb2 Mon Sep 17 00:00:00 2001 From: Przemek Rzad Date: Thu, 8 Aug 2024 17:14:24 +0200 Subject: [PATCH 6/6] Update ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b8d56e..4571b0b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,7 +69,7 @@ jobs: timeout-minutes: 15 # This is mentioned as example in the README: - - name: Build the node + - name: Build the node individually in release mode run: | # Save some space from debug builds rm -rf ./target