-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call misc-sync-templates after the stable release #6329
Comments
Last runs of misc-sync-templates.yml action failed like so: https://github.com/paritytech/polkadot-sdk/actions/runs/12466779475/job/34794912768. The error suggests that there is usage of dependency versions that conflicts with what's actually needed by the templates components (node/runtime). E.g. PSVM sets polkadot-sdk version to 0.1.0, which was released 18 months ago, while the most recent one was released 17 days ago, and I expected to pick the latest for stable2412. The same applies to other dependencies, set by PSVM to old versions, incompatible with the requested feature set (and probably, functionality). error: failed to select a version for Seems like using PSVM to set crates versions from the action doesn't work anymore, but not sure what brakes it. PSVM doesn't have other updates since 4 months ago, we install it from its GH repo, master branch. Probably one of its dependencies is broken, but hard to pin point. PRs were created for the first time the action failed (paritytech/polkadot-sdk-parachain-template#22). We can fix each PR one by one manually for now, but investigating why PSVM resolves crates versions for stable2412 in such a distant way (with old versions) should be covered next. cc @kianenigma |
# Description We're unable to sync templates repos with what's in polkadot-sdk/templates for stable2412 because the tag which references the release (`polkadot-stable2412`) is missing the Plan.toml file, which is needed by PSVM, ran when syncing, to update the templates dependencies versions in Cargo.tomls. This PR adds a workflow `patch` input, to enable the workflow to use PSVM with a tag corresponding to a patch stable release (e.g. `polkadot-stable2412-1`), which will contain the `Plan.toml` file. ## Integration This enables the templates repos update with the contents of latest stable2412 release, in terms of polkadot-sdk/templates, which is relevant for getting-started docs. ## Review Notes This PR adds a `patch` input for the `misc-sync-templates.yml` workflow, which if set will be used with `psvm` accordingly to update templates repos' dependencies versions based on upcomming patch stable2412-1, which contains the `Plan.toml`. The workflow will be ran manually after stable2412-1 is out and this work is tracked under #6329 . Signed-off-by: Iulian Barbu <[email protected]>
Placeholder issue which must be done after
stable2412
. We can also look into automating it bystable2412
release: #6374The text was updated successfully, but these errors were encountered: