New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Public keys are not correctly validated in `validateAddress` #1253

Open

TarikGul opened this issue Mar 22, 2023 · 0 comments

Labels

Member

TarikGul commented Mar 22, 2023

Currently in validateAddresss we accept publicKeys but they are not accepted as valid when they are.

The current implementation that is not working:

u8Address = Uint8Array.from(Buffer.from(address.slice(2), 'hex'));

Working implementation that breaks support for H160

u8Address = base58Decode(encodeAddress(hexToU8a(address)));

We need to find an implementation where it doesn't break support for ethereum addresses

The text was updated successfully, but these errors were encountered:

TarikGul added the I2 - Bug 🐜 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment