update copyright year to 2025 #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Feb 20, 2025
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit bab4c97)Here are some key observations to aid the review process:
|
niklasad1
approved these changes
Feb 24, 2025
lexnv
reviewed
Feb 24, 2025
| @@ -1,3 +1,3 @@ | |||
| // Copyright 2019-2023 Parity Technologies (UK) Ltd. | |||
| // Copyright 2019-2025 Parity Technologies (UK) Ltd. | |||
There was a problem hiding this comment.
dq: Maybe we can remove the years entirely? And do a similar update to polkadot-sdk?
// This file is part of Subxt.
// Copyright (C) Parity Technologies (UK) Ltd.
...
There was a problem hiding this comment.
would be better, I don't remember why the year is needed in the copywright header but "not a laywer" :)
There was a problem hiding this comment.
Yup agreed this would be better, though for now I'll just merge this PR to avoid looking into whether it matters at all :)
|
Persistent review updated to latest commit bab4c97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.