From 5f84a8bdd072074b443dc8b3fe229100d967be77 Mon Sep 17 00:00:00 2001 From: Mohammad Bagher Fakouri Date: Sun, 25 Dec 2022 02:59:47 +0330 Subject: [PATCH] fix: Include option in `getObject` feature is not working (#814) --- packages/dart/CHANGELOG.md | 6 ++++++ packages/dart/lib/src/base/parse_constants.dart | 2 +- packages/dart/lib/src/objects/parse_object.dart | 8 +++++--- packages/dart/pubspec.yaml | 2 +- packages/dart/test/parse_object_test.dart | 6 ++---- 5 files changed, 15 insertions(+), 9 deletions(-) diff --git a/packages/dart/CHANGELOG.md b/packages/dart/CHANGELOG.md index e56aa63be..f5eddf1fc 100644 --- a/packages/dart/CHANGELOG.md +++ b/packages/dart/CHANGELOG.md @@ -1,3 +1,9 @@ +## [3.1.9](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-3.1.8...dart-3.1.9) (2022-12-25) + +### Features + +* Include option in `getObject` feature is not working ([#813](https://github.com/parse-community/Parse-SDK-Flutter/issues/813)) + ## [3.1.8](https://github.com/parse-community/Parse-SDK-Flutter/compare/dart-3.1.7...dart-3.1.8) (2022-12-23) ### Features diff --git a/packages/dart/lib/src/base/parse_constants.dart b/packages/dart/lib/src/base/parse_constants.dart index be039d030..b0d26db62 100644 --- a/packages/dart/lib/src/base/parse_constants.dart +++ b/packages/dart/lib/src/base/parse_constants.dart @@ -1,7 +1,7 @@ part of flutter_parse_sdk; // Library -const String keySdkVersion = '3.1.8'; +const String keySdkVersion = '3.1.9'; const String keyLibraryName = 'Flutter Parse SDK'; // End Points diff --git a/packages/dart/lib/src/objects/parse_object.dart b/packages/dart/lib/src/objects/parse_object.dart index 772bf2e4f..5cc878c26 100644 --- a/packages/dart/lib/src/objects/parse_object.dart +++ b/packages/dart/lib/src/objects/parse_object.dart @@ -38,11 +38,13 @@ class ParseObject extends ParseBase implements ParseCloneable { Future getObject(String objectId, {List? include}) async { try { - String uri = '$_path/$objectId'; + String? query; if (include != null) { - uri = '$uri?include=${concatenateArray(include)}'; + query = 'include=${concatenateArray(include)}'; } - final Uri url = getSanitisedUri(_client, uri); + + final Uri url = + getSanitisedUri(_client, '$_path/$objectId', query: query); final ParseNetworkResponse result = await _client.get(url.toString()); return handleResponse( diff --git a/packages/dart/pubspec.yaml b/packages/dart/pubspec.yaml index d786ad7ad..66fc313b2 100644 --- a/packages/dart/pubspec.yaml +++ b/packages/dart/pubspec.yaml @@ -1,6 +1,6 @@ name: parse_server_sdk description: Dart plugin for Parse Server, (https://parseplatform.org), (https://back4app.com) -version: 3.1.8 +version: 3.1.9 homepage: https://github.com/parse-community/Parse-SDK-Flutter environment: diff --git a/packages/dart/test/parse_object_test.dart b/packages/dart/test/parse_object_test.dart index e08926e40..2b041400e 100644 --- a/packages/dart/test/parse_object_test.dart +++ b/packages/dart/test/parse_object_test.dart @@ -98,8 +98,7 @@ void main() { objectJsonDesiredOutput); expect(parseObject['img'].objectId, "8nGrLj3Mvk"); - expect(Uri.decodeComponent(result.path), - '/classes/MyUser/Mn1iJTkWTE?include=img'); + expect(Uri.decodeComponent(result.query), 'include=img'); }); test('should return expectedIncludeResult json when use getObject', @@ -178,8 +177,7 @@ void main() { objectJsonDesiredOutput); expect(parseObject['img'].objectId, "8nGrLj3Mvk"); - expect(Uri.decodeComponent(result.path), - '/classes/MyUser/Mn1iJTkWTE?include=img'); + expect(Uri.decodeComponent(result.query), 'include=img'); }); }); }