Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple guidelines to reflect new usage of labels and label groups as chips #3410

Open
mmenestr opened this issue Feb 15, 2023 · 3 comments · May be fixed by #4425 or #4338
Open

Update multiple guidelines to reflect new usage of labels and label groups as chips #3410

mmenestr opened this issue Feb 15, 2023 · 3 comments · May be fixed by #4425 or #4338

Comments

@mmenestr
Copy link
Collaborator

Get rid of chips guidelines, and write new guidelines for labels as chips.

Design issue here: patternfly/patternfly-design#1222

Background: We have decided to fully deprecate chips in favor of labels, which will cause the following changes:

  • Getting rid of the chip and chip group components
  • Creation a new compact label group component (will want to document this)
  • Change the standard label group component to match the new compact label group styling (will want to update images for this)
  • Update all Filter demos and table demos that include chips in them (will want to update images in Filters to match)
  • Update Multiple select component to include labels instead of chips inside the toggle (will want to update pictures of this in guidelines too)

All relevant details and mocks can be found here: https://www.sketch.com/s/d7e287f4-39e3-4c17-a302-2131d8f3ea87

@mcarrano
Copy link
Member

mcarrano commented Apr 10, 2023

This is on hold pending completion of patternfly/patternfly#5344 which has been moved to the post-V5 backlog. In the interim we want to just merge the documentation for Chip and Chip Group so they appear on the same page. Opened #3480 to track that work.

@mmenestr
Copy link
Collaborator Author

mmenestr commented May 6, 2024

@edonehoo - this seems to be something that is going to happen for PF6. In the staging, chips now have more of a label styling, but I guess we'll have to see exactly how we want to communicate this change in the guidelines. Leaving it on hold for now. Also created a PF6 design guidelines label to flag that this applies to the future state of PF!

@edonehoo
Copy link
Collaborator

edonehoo commented Oct 4, 2024

This will move towards completion as images are updated as part of a few of these #4235 (I'll update here when that one has moved more)

@edonehoo edonehoo added this to the 2024.Q4 milestone Oct 23, 2024
@kmcfaul kmcfaul moved this from In Progress to Parking lot in PatternFly Issues Oct 25, 2024
@kmcfaul kmcfaul removed the on hold label Oct 25, 2024
@edonehoo edonehoo moved this from Parking lot to In Progress in PatternFly Issues Nov 20, 2024
@edonehoo edonehoo linked a pull request Jan 6, 2025 that will close this issue
@edonehoo edonehoo moved this from In Progress to PR Review in PatternFly Issues Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: PR Review
4 participants