Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a loader prop for the Select components in v5.4.0 #11024

Open
aakankshabhende opened this issue Sep 19, 2024 · 6 comments
Open

Add a loader prop for the Select components in v5.4.0 #11024

aakankshabhende opened this issue Sep 19, 2024 · 6 comments

Comments

@aakankshabhende
Copy link

Describe the enhancement or change
Currently, we don't have a loader prop for Select components in v5.4.0 due to which we have to manually add a spinner in the component while the data is getting fetched.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 19, 2024
@tlabaj tlabaj moved this from Needs triage to Needs info in PatternFly Issues Sep 19, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Sep 19, 2024

@aakankshabhende here is the example of how to implement the view more functionality with our select component. https://www.patternfly.org/components/menus/select#with-view-more.

Does this solve yu\our use case?

@aakankshabhende
Copy link
Author

Actually, I wanted something similar to the LoadingVariant in PF4 where the loader was besides the placeholder.

@tlabaj
Copy link
Contributor

tlabaj commented Sep 20, 2024

@aakankshabhende can you please link the specific example. I can't seem to find it.

@aakankshabhende
Copy link
Author

Sorry for the late response. We get the loader when the value is selected and getting updated. Please check the attached video

Screen.Recording.2024-09-25.at.3.41.08.PM.mov

@kmcfaul kmcfaul removed the DevX label Oct 25, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@thatblindgeye
Copy link
Contributor

Hey @aakankshabhende . Can you confirm whether the behavior from your video above was a feature in PatternFly 4? It looks like the loadingVariant prop in v4 simply rendered a SelectOption with either a spinner or some text (depending what was passed to the prop), which would be similar to how the "view more" examples behave.

Or was this a new feature request to have a spinner as part of the toggle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs info
Development

No branches or pull requests

4 participants