-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a loader prop for the Select components in v5.4.0 #11024
Comments
@aakankshabhende here is the example of how to implement the view more functionality with our select component. https://www.patternfly.org/components/menus/select#with-view-more. Does this solve yu\our use case? |
Actually, I wanted something similar to the LoadingVariant in PF4 where the loader was besides the placeholder. |
@aakankshabhende can you please link the specific example. I can't seem to find it. |
Sorry for the late response. We get the loader when the value is selected and getting updated. Please check the attached video Screen.Recording.2024-09-25.at.3.41.08.PM.mov |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Hey @aakankshabhende . Can you confirm whether the behavior from your video above was a feature in PatternFly 4? It looks like the loadingVariant prop in v4 simply rendered a SelectOption with either a spinner or some text (depending what was passed to the prop), which would be similar to how the "view more" examples behave. Or was this a new feature request to have a spinner as part of the toggle? |
Describe the enhancement or change
Currently, we don't have a loader prop for Select components in v5.4.0 due to which we have to manually add a spinner in the component while the data is getting fetched.
The text was updated successfully, but these errors were encountered: