Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeBlock - aria attributes need updating in examples #11386

Open
thatblindgeye opened this issue Jan 8, 2025 · 0 comments
Open

CodeBlock - aria attributes need updating in examples #11386

thatblindgeye opened this issue Jan 8, 2025 · 0 comments

Comments

@thatblindgeye
Copy link
Contributor

Describe the enhancement or change
For both examples, the aria-label of the buttons should be updated:

  • the copy button should have an aria-label that conveys what will be copied, e.g. Copy to clipboard basic example code block.
  • The "play" button aria-label shouldn't have the word "icon" in it and either just be "Play" or follow the ClipboardCopy additional actions example and use "Run in web terminal" -- this should also have a tooltip aplied to it.

For the expandable example, the aria-labelledby on the expandable content points to a non-existent ID. Passing the same toggleId to both ExpandableSection and ExpandableSectionToggle will resolve this.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant