Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Charts - codesandbox text alignment #11442

Closed
kmcfaul opened this issue Jan 20, 2025 · 2 comments
Closed

Bug - Charts - codesandbox text alignment #11442

kmcfaul opened this issue Jan 20, 2025 · 2 comments

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Jan 20, 2025

After manually fixing the codesandbox imports (#11441) the alignment of the text in the legend, title and tooltips all appear to be incorrect. Additionally, the tooltips in dark theme are not appearing.

Codesandbox link:
https://codesandbox.io/p/sandbox/nervous-minsky-swg4p5?workspaceId=ws_JT5i8tC5QLevy3yVJPHU9e

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 20, 2025
@kmcfaul kmcfaul removed the PF Team label Jan 20, 2025
@kmcfaul kmcfaul changed the title Bug - Charts - codesandbox text alignment Bug - Charts - codesandbox text alignment & dark theme Jan 20, 2025
@dlabrecq
Copy link
Member

The CodeSandbox dependencies still uses @patternfly/react-charts v8.1.0. That version was affected by a recent Victory breaking change. However, the main examples are using the latest updates available in pre-release 8.2.0-prerelease.9.

The CodeSandbox (i.e., via patternfly.org) will pick up the fix when the next milestone is released.

Before
Image

After
Image

@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Jan 22, 2025
@dlabrecq dlabrecq changed the title Bug - Charts - codesandbox text alignment & dark theme Bug - Charts - codesandbox text alignment Jan 22, 2025
@dlabrecq
Copy link
Member

Regarding the dark theme, if you "open an example in a new window" or launch CodeSandbox, there isn't an option to toggle dark theme.

To enable dark theme for charts, see https://www.patternfly.org/developer-resources/dark-theme-handbook/#charts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants