Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - ToolbarToggleGroup - a11y error gets flagged due to aria-controls having invalid value #9827

Closed
thatblindgeye opened this issue Nov 17, 2023 · 2 comments

Comments

@thatblindgeye
Copy link
Contributor

Describe the problem
Before an update made in #9621 which conditionally renders the aria-controls attribute, some demos were getting a11y errors raised due to the fact that the value passed into the aria-controls prop was an invalid id (whatever element was meant to have that id wasn't rendered in the DOM, and aria-controls needs to be passed a valid id).

Per discussion with @jenny-s51 conditionally rendering aria-controls offers a (possibly temporary) fix to the a11y issue, but we should investigate whether or not that is a suitable fix long term. Ideally it may be better to have aria-controls always pointing to a valid element rather than conditionally applying the attribute.

How do you reproduce the problem?
Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.

Expected behavior
A clear and concise description of the expected behavior.

Is this issue blocking you?
List the workaround if there is one.

Screenshots
If applicable, add screenshots to help explain the issue.

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

What is your product and what release date are you targeting?

Any other information?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 27, 2025
@thatblindgeye
Copy link
Contributor Author

Going to close this since it hasn't seemed to have been an issue brought up since this was opened. Conditionally rendering the attribute should be fine for now and we can revisit if users are having issues.

@thatblindgeye thatblindgeye closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in PatternFly Issues Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants