Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PF6 - view full screen feature in react demo is glitchy #67

Closed
nicolethoen opened this issue Jun 3, 2024 · 7 comments · Fixed by #72
Closed

PF6 - view full screen feature in react demo is glitchy #67

nicolethoen opened this issue Jun 3, 2024 · 7 comments · Fixed by #72
Assignees
@HarpalSingh7395
Labels
bug Something isn't working P1 ⭐ released on @prerelease
Milestone
Prioritized Backlog

Comments

@nicolethoen
Copy link
Contributor

when closing full page mode, the log disappears

the toolbar on the full page mode has a black/missing background
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 3, 2024
@wise-king-sullyman wise-king-sullyman self-assigned this Jun 25, 2024
@wise-king-sullyman
Copy link
Collaborator

Moving to the backlog as these are not v6 specific issues, the same problems appear on main https://www.patternfly.org/extensions/log-viewer/react-demos

@wise-king-sullyman wise-king-sullyman removed their assignment Jun 25, 2024
@wise-king-sullyman wise-king-sullyman added bug Something isn't working and removed v6 alpha bug labels Jun 25, 2024
@HarpalSingh7395
Copy link
Contributor

@wise-king-sullyman Is there an opportunity for me to contribute to fixing this issue?

@nicolethoen
Copy link
Contributor Author

@HarpalSingh7395 you are welcome to contribute a fix! Please keep us updated as to your progress.
Or feel free to reach out if you have any questions!

@HarpalSingh7395
Copy link
Contributor

@nicolethoen Thank you for the opportunity! I'll get started on the fix and keep you updated on my progress. If I run into any questions, I'll be sure to reach out.

@HarpalSingh7395
Copy link
Contributor

@nicolethoen I have created a pull request that addresses the bug. Please let me know if there are any additional changes or improvements needed.

@nicolethoen nicolethoen mentioned this issue Jul 3, 2024
Merged
@HarpalSingh7395
Copy link
Contributor

@nicolethoen I fixed the linter issue.

@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.2.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarpalSingh7395 HarpalSingh7395

Labels
bug Something isn't working P1 ⭐ released on @prerelease
Projects
PatternFly Issues
Archived in project
Milestone
Prioritized Backlog
Development

Successfully merging a pull request may close this issue.

Fixed full screen react demo glitch. HarpalSingh7395/react-log-viewer
3 participants
@wise-king-sullyman @nicolethoen @HarpalSingh7395