Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y - Message content area obscured by top/bottom buttons when page is zoomed in #226

Open
rebeccaalpert opened this issue Oct 11, 2024 · 2 comments · May be fixed by #249
Open

a11y - Message content area obscured by top/bottom buttons when page is zoomed in #226

rebeccaalpert opened this issue Oct 11, 2024 · 2 comments · May be fixed by #249
Assignees
@rebeccaalpert
Labels
a11y-improvement bug Something isn't working needs design PF Team v6.x Applies to only the PF6 version
Milestone
2025.Q1

Comments

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Oct 11, 2024 •
edited
Loading

If the zoom is higher than 100% in the browser, the message content area can get obscured by the "to top/bottom" buttons (following screenshot at 125% zoom):

Image
@rebeccaalpert rebeccaalpert added a11y-improvement bug Something isn't working v6.x Applies to only the PF6 version labels Oct 11, 2024
@rebeccaalpert rebeccaalpert mentioned this issue Oct 11, 2024
Closed
@rebeccaalpert rebeccaalpert self-assigned this Oct 14, 2024
@kaylachumley
Copy link

Let's reduce the size of the current jump link buttons to 32px by 32px instead of the 40px by 40px. I think this should suffice for the time being...Can you please update the jumplinks to that size(not sure what that is in rems) and also can we keep them to the right instead of the original center aligned? Here it is in the figma file. Thanks! @rebeccaalpert

Image
Image

@rebeccaalpert rebeccaalpert linked a pull request Oct 17, 2024 that will close this issue
fix(JumpButton): Shrink it for now #249
Open
@rebeccaalpert rebeccaalpert mentioned this issue Oct 17, 2024
Open
@rebeccaalpert
Copy link
Member Author

Opening #250 to separately handle zoom conditions - I think we need some extra media queries here. We'll discuss at the Thursday group meeting what changes we want to do.

@kaylachumley kaylachumley mentioned this issue Oct 21, 2024
Open
@rebeccaalpert rebeccaalpert added this to the 2025.Q1 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebeccaalpert rebeccaalpert

Labels
a11y-improvement bug Something isn't working needs design PF Team v6.x Applies to only the PF6 version
Projects
PatternFly Issues
Status: PR Review
Milestone
2025.Q1
Development

Successfully merging a pull request may close this issue.

fix(JumpButton): Shrink it for now rebeccaalpert/virtual-assistant
2 participants
@rebeccaalpert @kaylachumley