Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Annotations HitTesting & Added annotation anchor #35

Closed
wants to merge 11 commits into from

Conversation

iakov-kaiumov
Copy link

@iakov-kaiumov iakov-kaiumov commented Mar 5, 2023

This PR implements several fixes and enchantments:

  1. Clickable SwiftUI Annotations! Handle annotation selection #4
  2. Added anchor parameter to the ViewMapAnnotation similar to the default SwiftUI Map approach.
  3. Fixed annotations centering problem MapAnnotations not centered properly #14. Thanks to @rderimay (I took solution from Integrated proposed code to center MapAnnotations properly #25)

P.S.
@pauljohanneskraft
The problem with your hittesting solution in the hit-testing branch was that the SwiftUI annotation view was not constrained to the underlying UIView. Therefore, when you moved the map, the SwiftUI view's position did not change. You may see in the picture below.
Снимок экрана 2023-03-04 в 21 59 45

@pauljohanneskraft
Copy link
Owner

Thank you for your contribution. I will open a similar pull request in the coming days, since I disagree with the addition of directions into this library (you could easily add this right now, so it doesn't need to be integrated in here). Also it seems that you dropped watchOS 6.0 support - however, this library tries to keep supporting all platforms starting at watchOS 6, macOS 10.15, iOS 13.0 and tvOS 13.0.

@iakov-kaiumov
Copy link
Author

@pauljohanneskraft
Hello! Thank you for your response. I now understand that integrating directions was pretty useless. I reverted this commit. Also, I'm sorry that I accidentally dropped watchOS 6.0 support while merging changes from #25. I reverted the changes and returned watchOS 6.0 support.

I would be happy to open new PR with these changes if you don't mind.

@pauljohanneskraft
Copy link
Owner

That sounds really great! Yes, thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants