Skip to content

Latest commit

 

History

History
114 lines (72 loc) · 3.24 KB

CONTRIBUTING.rst

File metadata and controls

114 lines (72 loc) · 3.24 KB
Raw

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

Bug reports

When reporting a bug please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Documentation improvements

Django AppSettings could always use more documentation, whether as part of the official Django AppSettings docs, in docstrings, or even on the web in blog posts, articles, and such.

Feature requests and feedback

The best way to send feedback is to file an issue at https://github.com/pawamoy/django-appsettings/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that code contributions are welcome :)

Development

To set up django-appsettings for local development:

  1. Fork django-appsettings (look for the "Fork" button).

  2. Clone your fork locally:

    git clone [email protected]:your_name_here/django-appsettings.git

  3. Create a branch for local development:

    git checkout -b name-of-your-bugfix-or-feature

    Now you can make your changes locally.

  4. When you're done making changes, run all the tests with one command:

    tox

  5. Commit your changes and push your branch to GitHub:

    git add .
git commit -m "Your detailed description of your changes."
git push origin name-of-your-bugfix-or-feature

  6. Submit a pull request through the GitHub website.

Pull Request Guidelines

If you need some code review or feedback while you're developing the code just make the pull request.

For merging, you should:

  1. Include passing tests (run tox) [1].
  2. Update documentation when there's new API, functionality etc.
  3. Add a note to CHANGELOG.rst about the changes.
  4. Add yourself to AUTHORS.rst.
[1]

If you don't have all the necessary python versions available locally you can rely on...

  • Travis: it will run the tests for each change you add in the pull request. It will be slower though...

  • pyenv:

    # important libraries to compile Python
sudo apt install -y libssl-dev openssl zlib1g-dev sqlite3 libsqlite3-dev libbz2-dev bzip2

git clone https://github.com/pyenv/pyenv.git ~/.pyenv
export PATH="${HOME}/.pyenv/bin:${PATH}"
export PYENV_ROOT="${HOME}/.pyenv"
eval "$(pyenv init -)"

pyenv install 3.5.3
pyenv install 3.6.0  # etc.
pyenv global system 3.5.3 3.6.0

Tips

To run a subset of tests:

tox -e envname -- pytest -k test_myfeature

To run the checks in parallel:

tox check -- -p auto

To run the tests in parallel:

tox test -- -p auto

To run all environments in parallel:

tox -p auto