Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: ecosystem-security-connectors should explicitly close its JAX-RS Clients / FISH-7621 #69

Open
kalgon opened this issue Jun 6, 2023 · 1 comment
Open

Bug Report: ecosystem-security-connectors should explicitly close its JAX-RS Clients / FISH-7621 #69

kalgon opened this issue Jun 6, 2023 · 1 comment
Assignees
@shub8968
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect

Comments

@kalgon
Copy link

kalgon commented Jun 6, 2023

Brief Summary

OAuth2AuthenticationMechanism opens a javax.ws.rs.client.Client but never closes it afterwards.

The javadoc of Client states:

Clients are heavy-weight objects that manage the client-side communication infrastructure. Initialization as well as disposal of a Client instance may be a rather expensive operation. It is therefore advised to construct only a small number of Client instances in the application. Client instances must be [properly closed] before being disposed to avoid leaking resources.

Using the standalone implementation of OIDC connector on JBoss/Wildfly gives the following warning:

[org.jboss.resteasy.client.jaxrs.i18n] (Finalizer) RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ApacheHttpClient43Engine instance for you. Please close clients yourself.

Expected Outcome

OAuth2AuthenticationMechanism should close Clients.

Current Outcome

OAuth2AuthenticationMechanism does not close Clients.

Reproducer

TBD

Operating System

Windows 10

JDK Version

Temurin 11.0.19.7

Ecosystem Tool

Security Connectors
@kalgon kalgon added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification Type: Bug Label issue as a bug defect labels Jun 6, 2023
@kalinchan kalinchan added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Jul 12, 2023
@kalinchan kalinchan reopened this Jul 12, 2023
@kalinchan
Copy link
Member

Hi @kalgon,

I will raise this issue to engineering under FISH-7621.

@kalinchan kalinchan changed the title Bug Report: ecosystem-security-connectors should explicitly close its JAX-RS Clients Bug Report: ecosystem-security-connectors should explicitly close its JAX-RS Clients / FISH-7621 Jul 12, 2023
@kalinchan kalinchan added Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Jul 12, 2023
@fturizo fturizo assigned shub8968 and unassigned kalinchan Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shub8968 shub8968

Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kalgon @shub8968 @kalinchan