Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive::v2::SessionError variants are not recoverable and must not return JSON #522

Open
DanGould opened this issue Feb 1, 2025 · 0 comments · May be fixed by #526
Open

receive::v2::SessionError variants are not recoverable and must not return JSON #522

DanGould opened this issue Feb 1, 2025 · 0 comments · May be fixed by #526

Comments

@DanGould
Copy link
Contributor

DanGould commented Feb 1, 2025

... because they can't

I've had an inkling this was the case since Jsonifying v2 errors. It also makes me question whether original-psbt-rejected is really the appropriate error code for v1::RequestErrors if any is appropriate at all.

This became even more apparent when implementing #520 since the into_url::Error is a client error that need not be returned to the sender, since they can't recover from it, unlike v1::RequestErrors.

DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 4, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
@DanGould DanGould linked a pull request Feb 4, 2025 that will close this issue
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 4, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 4, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 5, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 5, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 6, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 7, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
DanGould added a commit to DanGould/rust-payjoin that referenced this issue Feb 7, 2025
Only some errors are actually recoverable and must return JSON. Fix payjoin#522.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant