Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan9k is unusable due to messed up color palette #20

Open
DCNick3 opened this issue May 20, 2018 · 4 comments
Open

Plan9k is unusable due to messed up color palette #20

DCNick3 opened this issue May 20, 2018 · 4 comments

Comments

@DCNick3
Copy link

DCNick3 commented May 20, 2018

It looks like this in xterm (mintty gives similar results, so looks like this is not related to terminal)
image

@bauen1
Copy link

bauen1 commented Jun 16, 2019

This seems to be caused by the implementation of the cursor (bin/getty.lua unblink and reblink function) in plan9k (but the bug might still be in ocvm).
Commenting both functions out gives better (but still broken) results:
image
please note the 'e' that was typed while the cursor was unblinked (ie. black)

@Ocawesome101
Copy link

this is definitely an ocvm bug, but as far as i can tell only affects plan9k.

@Ocawesome101
Copy link

on looking through source and docs it appears this is due to a subtle behavior bug in OCVM's gpu.setForeground and gpu.setBackground methods: they should return the old foreground/background color, but instead return the new one. interestingly OCEmu and Ocelot do this too - i haven't yet tested in-game, but given that Plan9k works there i'd say it's a safe bet that OC proper does do this correctly.

Ocawesome101 added a commit to Ocawesome101/ocvm that referenced this issue Oct 2, 2022
@Ocawesome101
Copy link

Ocawesome101 commented Oct 2, 2022

so OCEmu and Ocelot probably were returning the correct values and my tests were just bad. OCVM still was returning incorrect ones though - #51 now fixes that too.

ETA: here's plan9k with the fix (the cursor does blink, i just didn't time the screenshot quite right for it to show :p):
Screenshot_20221002_005847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants