[PEAUTY-107] Impl sending estimate proposal #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
스레드의 동작을 protected 로 숨겼기 때문에 스레드 단일 테스트는 불가능 합니다
|
구두리뷰 받았습니다. 코드 정말 잘 짜신거같습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 [PEAUTY-107] Impl sending estimate proposal
Jira : PEAUTY-107
✨ 변경 사항
기능 추가/변경 설명
고객이 본인의 반려견 미용 제안을 여러 디자이너에게 할 수 있는 API 를 구현했습니다
스레드의 상태를 직접 변경할 수 있는 메소드들은 protected 로 바꿔 오직 process 를 통해 변경할 수 있게끔 만들었습니다
이에 따라 기존 스레드 단일 테스트가 불가능해져 비딩 시나리오 테스트로 통합했습니다
📅 작업 일정
Difference reason (If correct, no need.)
✔️ 확인 사항