-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PEAUTY-60] Create domain of relating to Puppy #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ค์ ๋ฆฌ๋ทฐํ๊ฒ ์ต๋๋ค : )
โฆinto feature/PEAUTY-60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum ์ ๋ํด ํ์ต์ ์ด์ฌํ ํ์ ๊ฒ ๋ณด์ด๋ค์ฅ ๊ณ ์ํ์
จ์ต๋๋ค!
๋ช ๊ฐ์ง ๋ณ๊ฒฝ ์์ฒญ ๋จ๊ฒจ์ ํ์ธ ๋ถํ๋๋ฆฝ๋๋ค ๐
peauty-domain/src/main/java/com/peauty/domain/puppy/Disease.java
Outdated
Show resolved
Hide resolved
peauty-domain/src/main/java/com/peauty/domain/puppy/Disease.java
Outdated
Show resolved
Hide resolved
Refactor Exception Type, Using IllegalArgumentsException, Receiving the INTERNAL_SERVER_ERROR
add about Breed, Disease, Sex, Size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฆฌ๋ทฐ ๋ฐ์ ๊ฐ์ฌํฉ๋๋ค!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ENUM๊ณผ ๊ณตํต ์์ธ์ ๋ํด์ ์ด๋ฒ ๋ฆฌ๋ทฐ๋ฅผ ํตํด์ ๋ค์ ํ๋ฒ ์๊ณ ๊ฐ๊ฒ ๋๋ค์ : )
LGTM ๐
|
โฐ(ยฐโฝยฐ)โฏ |
๐ PEAUTY-60 Create domain of relating to Puppy
Jira : PEAUTY-60
โจ ๋ณ๊ฒฝ ์ฌํญ
Puppy, Sex, Image ๋๋ฉ์ธ์ ์ถ๊ฐํ์ต๋๋ค.
๐ ์์ ์ผ์
Difference reason (If correct, no need.)
โ๏ธ ํ์ธ ์ฌํญ