Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PEAUTY-60] Create domain of relating to Puppy #9

Merged
merged 12 commits into from
Nov 24, 2024

Conversation

Shanate
Copy link
Contributor

@Shanate Shanate commented Nov 22, 2024

๐Ÿ“„ PEAUTY-60 Create domain of relating to Puppy

Jira : PEAUTY-60

โœจ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ๋ฐ˜๋ ค๊ฒฌ ๊ด€๋ จ ๋„๋ฉ”์ธ ์ถ”๊ฐ€

Puppy, Sex, Image ๋„๋ฉ”์ธ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“… ์ž‘์—… ์ผ์ •

  • Expected MD: 1 MD
  • Actual MD: 1 MD

Difference reason (If correct, no need.)

  • None.

โœ”๏ธ ํ™•์ธ ์‚ฌํ•ญ

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ–ˆ๋‚˜์š”?
  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๊ฐ€ ์ถ”๊ฐ€๋˜์—ˆ๋‚˜์š”?
  • ๋ฌธ์„œ๊ฐ€ ์—…๋ฐ์ดํŠธ๋˜์—ˆ๋‚˜์š”?

Copy link
Contributor

@harvartz harvartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ค์‹œ ๋ฆฌ๋ทฐํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค : )

@harvartz harvartz self-assigned this Nov 22, 2024
@harvartz harvartz added the ๐Ÿ› ๏ธ ๊ธฐ๋Šฅ New feature or request label Nov 22, 2024
@Shanate Shanate assigned Shanate and unassigned harvartz Nov 23, 2024
@Shanate Shanate requested a review from weejinyoung November 23, 2024 04:31
Copy link
Contributor

@weejinyoung weejinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enum ์— ๋Œ€ํ•ด ํ•™์Šต์„ ์—ด์‹ฌํžˆ ํ•˜์‹  ๊ฒŒ ๋ณด์ด๋„ค์šฅ ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!
๋ช‡ ๊ฐ€์ง€ ๋ณ€๊ฒฝ ์š”์ฒญ ๋‚จ๊ฒจ์š” ํ™•์ธ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค ๐Ÿ™‡

Copy link
Contributor

@weejinyoung weejinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ๋ฐ˜์˜ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

Copy link
Contributor

@harvartz harvartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENUM๊ณผ ๊ณตํ†ต ์˜ˆ์™ธ์— ๋Œ€ํ•ด์„œ ์ด๋ฒˆ ๋ฆฌ๋ทฐ๋ฅผ ํ†ตํ•ด์„œ ๋‹ค์‹œ ํ•œ๋ฒˆ ์•Œ๊ณ  ๊ฐ€๊ฒŒ ๋˜๋„ค์š” : )
LGTM ๐Ÿ‘

@harvartz harvartz merged commit ad0fc77 into release/v0.1.0 Nov 24, 2024
1 check passed
@Shanate
Copy link
Contributor Author

Shanate commented Nov 24, 2024

๋ฆฌ๋ทฐ ๋ฐ˜์˜ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!
๐ŸŽ‰

@Shanate
Copy link
Contributor Author

Shanate commented Nov 24, 2024

ENUM๊ณผ ๊ณตํ†ต ์˜ˆ์™ธ์— ๋Œ€ํ•ด์„œ ์ด๋ฒˆ ๋ฆฌ๋ทฐ๋ฅผ ํ†ตํ•ด์„œ ๋‹ค์‹œ ํ•œ๋ฒˆ ์•Œ๊ณ  ๊ฐ€๊ฒŒ ๋˜๋„ค์š” : ) LGTM ๐Ÿ‘

โ•ฐ(ยฐโ–ฝยฐ)โ•ฏ

@harvartz harvartz deleted the feature/PEAUTY-60 branch December 4, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants