Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented dependency on Tipsy #2

Open
cmaitchison opened this issue Jun 19, 2014 · 1 comment
Open

Undocumented dependency on Tipsy #2

cmaitchison opened this issue Jun 19, 2014 · 1 comment

Comments

@cmaitchison
Copy link

This gem uses $.tipsy, which can come as a surprise because it is not bundled with this gem or included in the README as a dependency.

peek-dalli/app/assets/javascripts/peek/views/dalli.coffee

Line 9 in b58dea8

.tipsy

@jonah-williams
Copy link

I was confused by this for a minute as well but it's a vendored part of peek: https://github.com/peek/peek/blob/master/app/assets/javascripts/peek/vendor/jquery.tipsy.js so I don't know that an explicit dependency declaration is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonah-williams @cmaitchison