Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground syntax highlight grammar breaks when using template literals #423

Closed
KrofDrakula opened this issue Jul 22, 2023 · 4 comments
Closed
Labels
duplicate This issue or pull request already exists

Comments

@KrofDrakula
Copy link

Was playing around with the online playground and noticed that template strings break highlighting when using interpolation:

image

The file still parses correctly but the highlighting is broken from that point onwards.

@hildjj
Copy link
Contributor

hildjj commented Jul 22, 2023

Good catch. I'm going to mark this one as "help wanted", and see if someone who knows how the highlighting works can send a PR.

@hildjj hildjj added the help wanted Extra attention is needed label Jul 22, 2023
@KrofDrakula
Copy link
Author

Might be related to #296.

@reverofevil
Copy link

Yeah, it's been a problem of CodeMirror's JS grammar for ages. Really should switch from CM to something else.

@hildjj
Copy link
Contributor

hildjj commented Jul 22, 2023

Let's talk about options on #296. I agree that's the correct, lowest-effort approach to solving this.

Going to close this as a dup.

@hildjj hildjj closed this as completed Jul 22, 2023
@hildjj hildjj added duplicate This issue or pull request already exists and removed help wanted Extra attention is needed labels Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants