Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong search result #281

Open
artemChernitsov opened this issue Jan 19, 2022 · 8 comments
Open

Wrong search result #281

artemChernitsov opened this issue Jan 19, 2022 · 8 comments
Labels
bug Something isn't working

Comments

@artemChernitsov
Copy link

Describe the bug

Incorrect locality in search results in WI, USA (North America project)

Steps to Reproduce
Just enter in search "639 Baxter Drive Mukwonago"
https://www.mapzen.com/products/search/geocoding/?query=639%20Baxter%20Drive%20Mukwonago&endpoint=autocomplete&gid=whosonfirst%3Alocality%3A101732227&selectedLat=42.86211&selectedLng=-88.32353&lng=-88.32979&lat=42.85187&zoom=13.377551249626974

Expected behavior
Locality must be Mukwonago, not Waterford.

@artemChernitsov artemChernitsov added the bug Something isn't working label Jan 19, 2022
@missinglink
Copy link
Member

this is due to there being two overlapping polygons:

both claim to be sourced from uscensus which usually doesn't have overlapping polygons 🤔
note there is also the localadmin -> https://spelunker.whosonfirst.org/id/404495653/

I'm not familiar with the area, please open an issue on the whosonfirst-data repo to see if it can be fixed:
https://github.com/whosonfirst-data/whosonfirst-data/issues

@missinglink
Copy link
Member

You may find the new compare app easier to use than the old Mapzen homepage:
https://pelias.github.io/compare/#/v1/autocomplete?text=639+Baxter+Drive+Mukwonago

@missinglink
Copy link
Member

I just had a look again and the polygons don't overlap:

Screenshot 2022-01-20 at 11 07 11

I think there is something else going on, possibly that this has been fixed and we haven't imported the new data, will let you know.

missinglink added a commit to pelias/wof-admin-lookup that referenced this issue Jan 20, 2022
Add USA locality override for zip 53149 -> Mukwonago
pelias/docker#281
@missinglink
Copy link
Member

the issue was in our postal-cities mapping, I've fixed it via pelias/wof-admin-lookup@0ea09e0 but it will take some time to propagate through the stack

@artemChernitsov
Copy link
Author

Thanks @missinglink
Should I make a rebuild of all my Pelias instance?
Or maybe exist some other mechanism to safely update my Pelias instance?

@missinglink
Copy link
Member

missinglink commented Jan 20, 2022

There isn't a method to update an existing instance, it always requires a rebuild by design.

Because of the dependencies, this change won't be pulled into the pelias/openaddresses:master docker image until the next merge on the master branch of that repo.

It's a fair bit of work to rebuild for one locality name change, I'd generally just recommend waiting a bit longer and rebuilding every few months unless it's really important.

@artemChernitsov
Copy link
Author

@missinglink unfortunately it's very important to our app which using Pelias, can I manually make changes in my instance and make pelias preparation for wof, and then import all datasets again to save time of preparing?

@missinglink
Copy link
Member

I just merged a PR on pelias/openaddresses, once this job completes then you can pull the latest docker images and rebuild https://github.com/pelias/openaddresses/actions/runs/1723109743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants