Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logs written to stderr #60

Closed
jnorkus opened this issue Feb 22, 2022 · 0 comments · Fixed by #62
Closed

Debug logs written to stderr #60

jnorkus opened this issue Feb 22, 2022 · 0 comments · Fixed by #62
Labels

Comments

@jnorkus
Copy link
Contributor

jnorkus commented Feb 22, 2022

Describe the bug
Debug logs are written to stderr, which causes them to appear as errors in Google Cloud.

Expected behavior
Only errors should go to stderr. Even better, that should be configurable.

Additional context
After some digging I found out that the version of Winston currently used has this default setting:

stderrLevels: { error: true, debug: true }

Latest version of Winston defaults to nothing being written to stderr:

stderrLevels: {}

My suggestion is to add a stderrLevels logger setting in pelias.config. I can submit a PR.

References

Upgrade to Winston 3 issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant