Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumericStreet: New classification for streets starting with a number #175

Open
JanF01 opened this issue Jul 26, 2023 · 0 comments · May be fixed by #176
Open

NumericStreet: New classification for streets starting with a number #175

JanF01 opened this issue Jul 26, 2023 · 0 comments · May be fixed by #176
Labels
enhancement New feature or request

Comments

@JanF01
Copy link
Contributor

JanF01 commented Jul 26, 2023

Use-cases

Hi, I have found that there are many streets in Poland that begin with a NumericClassifier. To name some: 1 Maja , 3 Maja, 11 Listopada, 29 listopada , 1 Pułku.

Specificaly I'm having those problems when sending autocomplete requests:

/autocomplete?focus=50.089106, 19.957787&text=11 listopada 2/4&layer=address
results:

"places": []

If the streets were to be properly recognized and the housenumber separated:

"places": [
        {
            "gid": "openaddresses:address:pl/mazowieckie:261ea02d958e2be8",
            "label": "11 Listopada 2/4, Radom, MZ, Polska",
            ...

Attempted Solutions

I have added a classification scheme for cases like aleja 29 Listopada aleja 11 listopada

{
    // Aleja 11 Listopada 
    confidence: 0.84,
    Class: StreetClassification,
    scheme: [
      {
        is: ['StreetPrefixClassification'],
        not: ['StreetClassification', 'IntersectionClassification']
      },
      {
        is: ['NumericClassification'],
        not: ['StreetClassification', 'IntersectionClassification']
      },
      {
        is: ['AlphaClassification', 'GivenNameClassification', 'PersonClassification'],
        not: ['StreetClassification', 'StreetPrefixClassification']
      }
    ]
 }

This classification works with all tests passed.
On the other hand ( which is understandable ), such classification fails on multiple tests:

{
    // 11 Listopada 
    confidence: 0.84,
    Class: StreetClassification,
    scheme: [
      {
        is: ['NumericClassification'],
        not: ['StreetClassification', 'IntersectionClassification']
      },
      {
        is: ['AlphaClassification', 'GivenNameClassification', 'PersonClassification'],
        not: ['StreetClassification', 'StreetPrefixClassification']
      }
    ]
 }

Proposal

My proposal would be to create a new Classification, specificaly with words that could appear after a NumericClassification and create a street name altogether instead of beeing a separate entity.

@JanF01 JanF01 added the enhancement New feature or request label Jul 26, 2023
@JanF01 JanF01 linked a pull request Aug 18, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant