Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new StreetNumericClassification #176

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

JanF01
Copy link
Contributor

@JanF01 JanF01 commented Aug 18, 2023

👋 I thought about how to solve #175 . I came up with adding a new StreetNumericClassification. I'm aware that it is a very country specific case.


Here's the reason for this change 🚀

As stated in #175, Poland has a lot of Street Names that start with numbers, we have found over a 1500 such streets in the database and just creating schemes for them is not a possibility as the 2nd, 3rd and so on words should be classified accordingly. I would be open for any different ideas to solving this issue.


Here's what actually got changed

  • Added StreetNumericClassification and StreetNumericClassifier
  • Added numeric_streets.txt to the pelias dictionary with keywords that in most cases begin a Numeric Street
  • Added schemes for Numeric Streets with 1,2,3 or 4 word length

Here's how others can test the changes 👀

I have added unit tests for the StreetNumericClassifier

Closes #175

@JanF01
Copy link
Contributor Author

JanF01 commented Sep 4, 2023

@missinglink @Joxit I would appreciate your insights on whether the proposed solution is suitable for inclusion or if it requires revisions. Thank you for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumericStreet: New classification for streets starting with a number
1 participant