feat: add new StreetNumericClassification #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I thought about how to solve #175 . I came up with adding a new
StreetNumericClassification
. I'm aware that it is a very country specific case.Here's the reason for this change 🚀
As stated in #175, Poland has a lot of Street Names that start with numbers, we have found over a 1500 such streets in the database and just creating schemes for them is not a possibility as the 2nd, 3rd and so on words should be classified accordingly. I would be open for any different ideas to solving this issue.
Here's what actually got changed
StreetNumericClassification
andStreetNumericClassifier
Here's how others can test the changes 👀
I have added unit tests for the
StreetNumericClassifier
Closes #175