Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge this code back into pelias/api #86

Open
orangejulius opened this issue Jun 28, 2018 · 2 comments
Open

Merge this code back into pelias/api #86

orangejulius opened this issue Jun 28, 2018 · 2 comments
Labels

Comments

@orangejulius
Copy link
Member

orangejulius commented Jun 28, 2018

A few years back we split this code out, I think to set up for the possibility that more areas of our code would make calls to Elasticsearch besides just the API.

This hasn't panned out, and now there's a bit of extra friction to changing our query code, since we have to make changes in this repo, and then update the version in the API.

For development, it introduces a lot of extra work, especially for a Docker based approach, but also locally, as running npm link correctly is at best a timewaster, and easy to get wrong.

Unless we have a really good reason I'm forgetting, I think we should move all this code back into https://github.com/pelias/api. It would be one less package/repo to manage.

@missinglink, your thoughts?

@missinglink
Copy link
Member

Sounds fair, I think there is value to having all the query generation code in one place, but I'm happy if that place is a directory inside pelias/api.

@orangejulius
Copy link
Member Author

Yeah that's the thing, there's some query views still in the API :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants