Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint javascript #311

Open
missinglink opened this issue Aug 7, 2018 · 0 comments · May be fixed by #344
Open

lint javascript #311

missinglink opened this issue Aug 7, 2018 · 0 comments · May be fixed by #344

Comments

@missinglink
Copy link
Member

missinglink commented Aug 7, 2018 •
edited
Loading

for some reason code in this repo doesn't seem to conform to our usual jslint config.

just noticed this code:

if( isForced() ) drop();
else prompt( drop, fail );

we usually enforce curly braces around if statements.
orangejulius added a commit that referenced this issue Nov 3, 2018
@orangejulius
chore(test): Add precommit-hook
2bc9408 
This was never set up, and thus we have not been linting code in this
repository.

Fixes #311
orangejulius added a commit that referenced this issue Dec 3, 2018
@orangejulius
chore(test): Add precommit-hook
8ced5e2 
This was never set up, and thus we have not been linting code in this
repository.

Fixes #311
orangejulius added a commit that referenced this issue Feb 8, 2019
@orangejulius
chore(test): Add precommit-hook
ae7c177 
This was never set up, and thus we have not been linting code in this
repository.

Fixes #311
@orangejulius orangejulius linked a pull request Feb 8, 2019 that will close this issue
Open
orangejulius added a commit that referenced this issue Jun 10, 2019
@orangejulius
chore(test): Add precommit-hook
4257e45 
This was never set up, and thus we have not been linting code in this
repository.

Fixes #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(test): Add precommit-hook pelias/schema
1 participant
@missinglink