Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to 8443 if https #702

Closed

Conversation

RMartinOscar
Copy link
Contributor

No description provided.

@RMartinOscar RMartinOscar self-assigned this Nov 7, 2024
@RMartinOscar RMartinOscar requested review from notAreYouScared and Boy132 and removed request for notAreYouScared November 7, 2024 04:54
@Boy132
Copy link
Member

Boy132 commented Nov 7, 2024

Why? There is no reason to always default to 8443 if using https.

@RMartinOscar
Copy link
Contributor Author

Feels wrong to server https over a http port; Maybe i should set it to 4443 instead of 8443 even 🤔

@Boy132
Copy link
Member

Boy132 commented Nov 7, 2024

8080 is not a http port per se. Just with cloudflare.

@RMartinOscar
Copy link
Contributor Author

8080 is not a http port per se. Just with cloudflare.

So you would serve https over 81 without thinking about it ?

@Boy132
Copy link
Member

Boy132 commented Nov 7, 2024

8080 is not a http port per se. Just with cloudflare.

So you would serve https over 81 without thinking about it ?

Wings doesn't care about the port. 81 would work with https, 444 with http.
As long as there is no software limitation it makes no sense to have two default ports. That just adds unnecessary complexity.

@RMartinOscar RMartinOscar deleted the fix/default-8443-https branch November 7, 2024 22:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants