-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdminerJsonPreview generates error #8
Comments
I can't imagine a way how AdminerJsonPreview plugin can cause this error. This plugin modifies different parts of HTML page. You are referring to this code: var menu = document.getElementById("menu");
var button = menu.getElementsByTagName("h1")[0]; Variable |
Well... here's the thing: I believe is some racing condition here. When using this plugin, the error is thrown before the entire page gets loaded ( so to answer to your question: no, there is no |
Could you provide more details? What browser do you use, what Adminer page do you open and what plugins do you use? |
Sure: using latest Chrome on macOS ( Catalina ), Adminer v4.7.8 with these plugins only:
Regards! |
On one of my servers, when enabling this plugin, the page load is interrupted when viewing data that contains JSON objects. The error I see in chrome console is:
Uncaught TypeError: Cannot read property 'getElementsByTagName' of null at HTMLDocument.init
However, I noticed the error is triggered by line #77 in AdminerTheme.php ( although, I emphasize it only happens when JSON plugin is loaded ).
About env.:
OS: Ubuntu 18.04.5 LTS
Webserver: Apache 2
The text was updated successfully, but these errors were encountered: