-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the reference_timestamp & reference_id be set in server only mode? #1718
Comments
We don't use the reference timestamp in ntpd-rs, as putting an accurate timestamp in that field leaks information that may make certain types of attacks significantly easier. I did not realize that this field was actually used by any implementation, as the ntpv4 standard does not. What you describe as a stopgap PR actually seems to me like a very good solution, also long term. In the very long term the field will disappear anyway, as it is currently slated to be removed in ntpv5. |
As for adding a configuration option for setting the reference, I think we would be open to that, though for technical reasons we should probably not have it be part of the server section, but rather the synchronization section. We may also want to have a look at how we want this to behave exactly (should it just be an initial value, or a complete override). Feel free to open a feature request issue for this. |
Just as an aside: you really should try and get away from ntpdate. It very much is deprecated, most modern Linux distributions no longer ship it at all (and haven't for a couple of years). It doesn't protect your system against weird time jumps at all. Even just switching to something like systemd-timesyncd would help a lot. |
Ideally yes - hence the interest in ntpd-rs - but many of the products I work with are unlikely to get complete system updates, so compliance is with the RFC is the only thing I can go on (in the hope that their ntp solution is compliant that is - the likes of Yocto and Busybox based builds are prevelant). In any case, the "Reference ID" is not nearly as simple as it looked on first pass - and an incomplete implementation is much worse than a technically correct solution, so this might take a little more time than I had expected! |
ntpdate is indeed ancient and mostly unmaintained, but it is interesting in a historical context. I suspect if you spelunk the NTP v3 (or even earlier) code you'll see it was used at least as ntpdate does as a sanity check. It may also have been used in earlier source selection logic. Jamming the receive timestamp in seems like the wrong answer to me. That's claiming the clock was last adjusted to its source the same moment the request came in. Yes, it fixes the ntpdate issue, but that's the only good thing I can say about it. If ntpd-rs in server mode really has no knowledge of when its clock was last synchronized, why not put in a time in the recent past and zero the fractional part? Wouldn't that satisfy old ntpdate code as well as provide enough data minimization to address the concern of easing some attack(s)? For example, the transmit time truncated to 64 seconds by masking against ~63 (or 0xffffffc0 if that suits). |
It looks like NIST NTP servers are already doing something similar, truncating the reference timestamp 8 bits left of the decimal point:
|
Actually it looks like NIST zeroes the last 7 bits of the seconds field (and the fractional part), not 8 bits. Therefore the last two hex digits of the seconds part are either 00 or 80, giving a granularity of 128 seconds for the reference timestamp. I'll leave the exact implementation details to you, but I would much prefer that the reference timestamp would contain some reasonably sane value, perhaps one that is truncated like suggested above. I'm one of the server operators in the NTP pool, and I can imagine that some of those pool clients use all kinds of odd and outdated software to sync their time, including ntpdate. For reference, the ntpdate in CentOS 7 requires the "reference time" value in NTP responses. Yes, CentOS 7 went EOL half a year ago, but that did not suddenly wipe out all the existing C7 installations off the planet. The story could be similar in various embedded systems that were installed a decade ago or so. |
I will follow their lead and zero the last 7 bits. I started on the reference_id but very quickly discovered a "can of worms" and only got as far as documenting what the functionality should be rather than implementing any of it. I have to allocate a bit more time to the problem, but I will get the reference_timestamp ready first as that doesn't involve md5 hashes of ipv6 addresses... |
FWIW: there is more software, besides ntpdate, that looks at the Reference Timestamp: |
RFC5905(NTPv4) appendix mentions: "... reference time not later than the transmit time." [I've seen this happen.] Some current NTP servers set the root dispersion to a fixed value. The reference time may help identify dubious servers among those. NIST servers vary. Their FPGA-based implementations set reference time to (int) transmit time. I have no objections to NTP clients setting the reference time to 0 or something else in their Mode 3 requests. |
I am attempting to configure
ntpd-rs
as a server for a system where the system time is being conditioned bygpsd
.My configuration is:
The response packets from
ntpd
making a request are parsed by wireshark as being:And the error I am getting from
ntpdate
is:(I know ntpdate is deprecated, but I believe it should still work?) The offending area in
ntpdate
is:Where NTP_MAXAGE is set to 1 day. I do not think check is present in
ntpd
itself.According to RFC5905:
Digging around I think the response builder (https://github.com/pendulum-project/ntpd-rs/blob/main/ntp-proto/src/packet/mod.rs#L233) is settings this to default and there is no other mechanism to configure it.
Would you be amenable to a stopgap PR which set the reference_timestamp to the receive_timestamp? (i.e. in the absence of an exact time the clock was last updated we can go with something very recent, rather than the epoch)
I would also like to add a configuration option to allow the reference ID word to be set in the [[server]] section of the configuration via a string.
Finally, if the server is running with established sources the reference_timestamp could be set to the actual time of the last completed poll event - but I have not looked in to the mechanics of that and expect there to be some cross-thread shenanigans required.
If these are of use I can find some time to do the work.
The text was updated successfully, but these errors were encountered: