From f3bf26b081d0ab0a52bf38ffadf8be0ff3dd1fad Mon Sep 17 00:00:00 2001
From: Owen Lester <owlester@sas.upenn.edu>
Date: Tue, 17 Dec 2024 14:57:53 -0500
Subject: [PATCH] Wharton Dashboard fixes

---
 .../Settings/WhartonApplicationStatus.tsx     | 83 ++++++++++++++++---
 1 file changed, 70 insertions(+), 13 deletions(-)

diff --git a/frontend/components/Settings/WhartonApplicationStatus.tsx b/frontend/components/Settings/WhartonApplicationStatus.tsx
index 24d369a5a..8d03303ee 100644
--- a/frontend/components/Settings/WhartonApplicationStatus.tsx
+++ b/frontend/components/Settings/WhartonApplicationStatus.tsx
@@ -1,5 +1,6 @@
 import React, { ReactElement, useState } from 'react'
-import { DiscreteColorLegend, Hint, RadialChart } from 'react-vis'
+import { Hint, RadialChart } from 'react-vis'
+import styled from 'styled-components'
 
 import { WHITE } from '~/constants/colors'
 import { ApplicationStatus } from '~/types'
@@ -29,24 +30,46 @@ const colors = {
 
 function parseStatuses(statuses: ApplicationStatus[]): PieChartData {
   const applicationsTotal = {}
+  const applicationCommittees = {}
   const applicationsGrouped: PieChartData = {}
   statuses.forEach((status) => {
-    if (!(status.name in applicationsGrouped)) {
+    if (!(status.name in applicationCommittees)) {
       const total = {}
       Object.keys(colors).forEach((status) => (total[status] = 0))
       applicationsTotal[status.name] = total
 
-      const grouped = {}
-      grouped[status.committee] = []
-      applicationsGrouped[status.name] = grouped
-    } else if (!(status.committee in applicationsGrouped[status.name])) {
-      applicationsGrouped[status.name][status.committee] = []
+      applicationCommittees[status.name] = {}
+    }
+    if (!(status.committee in applicationCommittees[status.name])) {
+      applicationCommittees[status.name][status.committee] = {}
+    }
+    if (
+      !(status.status in applicationCommittees[status.name][status.committee])
+    ) {
+      applicationCommittees[status.name][status.committee][status.status] = 0
     }
     applicationsTotal[status.name][status.status] += status.count
-    applicationsGrouped[status.name][status.committee].push({
-      angle: status.count,
-      label: status.status,
-      color: colors[status.status],
+    applicationCommittees[status.name][status.committee][status.status] +=
+      status.count
+  })
+
+  /* Does application name even matter? */
+
+  Object.keys(applicationCommittees).forEach((name) => {
+    Object.keys(applicationCommittees[name]).forEach((committee) => {
+      Object.keys(applicationCommittees[name][committee]).forEach((status) => {
+        if (!(name in applicationsGrouped)) {
+          applicationsGrouped[name] = {}
+        }
+        if (!(committee in applicationsGrouped[name])) {
+          applicationsGrouped[name][committee] = []
+        }
+        applicationsGrouped[name][committee].push({
+          angle: applicationCommittees[name][committee][status],
+          label: status,
+          color: colors[status],
+        })
+      })
     })
   })
 
@@ -67,6 +90,41 @@ function parseStatuses(statuses: ApplicationStatus[]): PieChartData {
   return applicationsGrouped
 }
 
+const LegendContainer = styled.div`
+  height: 130px;
+  display: grid;
+  rowGap: "0.5rem",
+  alignItems: "center"
+`
+
+const LegendColor = styled.div<{ color: string }>`
+  background-color: ${(props) => props.color};
+`
+const LegendRow = styled.div`
+  display: grid;
+  grid-template-columns: 20px auto;
+  gap: 6px;
+`
+
+interface LegendProps {
+  items: {
+    color: string
+    title: string
+  }[]
+}
+const Legend: React.FC<LegendProps> = ({ items }) => {
+  return (
+    <LegendContainer>
+      {items.map((item, index) => (
+        <LegendRow>
+          <LegendColor key={index} color={item.color} />
+          <div style={{ alignSelf: 'center' }}>{item.title}</div>
+        </LegendRow>
+      ))}
+    </LegendContainer>
+  )
+}
+
 function StatusCard({
   application,
   pieData,
@@ -203,10 +261,9 @@ const WhartonApplicationStatus = ({
         Download Data
       </button>
       <div className="column">
-        <DiscreteColorLegend
+        <Legend
           items={Object.keys(colors).map((label) => ({
             title: label,
-            strokeWidth: 100,
             color: colors[label],
           }))}
         />