Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task - Add Java 21+ Support #66

Closed
michaeltchuang opened this issue Dec 10, 2024 · 1 comment · Fixed by #123
Closed

Task - Add Java 21+ Support #66

michaeltchuang opened this issue Dec 10, 2024 · 1 comment · Fixed by #123
Assignees
Labels
external contribution open source code contributions gitops gitops tasks

Comments

@michaeltchuang
Copy link
Collaborator

Task - New macbooks have Java 21 installed instead of Java 17 by default….app module needs to be upgraded to support this.

The error you get is this if it’s not fixed

Invalid value (21) passed to --jvm-target, must be one of [1.6, 1.8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18]

Temporary workaround...switch gradle to use Java 17 in Android Studio

image

Also you can to add to your gradle.properties,

org.gradle.java.home=/opt/homebrew/opt/openjdk@17

@michaeltchuang michaeltchuang self-assigned this Dec 10, 2024
@michaeltchuang michaeltchuang added external contribution open source code contributions gitops gitops tasks labels Dec 10, 2024
@alexs60
Copy link
Contributor

alexs60 commented Dec 10, 2024

I had an investigation on this issue.
Screenshot 2024-12-10 at 6 21 16 PM
This issue seems related to detekt as library.
This issue that comes from the dependency seems that is already solved here:

  1. Fails to run with Kotlin 1.9.20 and Java 21 detekt/detekt#6645
  2. Support Jvm 22 detekt/detekt#7458
    As mentioned this will be solved with the next release of Detekt. Right now we are running the detekt = "1.23.7" that is already the latest as of today

cc: @michaeltchuang

@michaeltchuang michaeltchuang linked a pull request Jan 31, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contribution open source code contributions gitops gitops tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants