Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.6 and other improvements #33

Open
macguirerintoul opened this issue Jul 31, 2018 · 6 comments
Open

Laravel 5.6 and other improvements #33

macguirerintoul opened this issue Jul 31, 2018 · 6 comments

Comments

@macguirerintoul
Copy link

Hi @petehouston, I'd like to contribute an updated guide for Laravel 5.6. I've also tested it on a new provider, Web Hosting Canada.

There are a few other things in the instructions that I would change, including the part about symbolic links. In my experience, deploying works much better if symbolic links are made the other way around, i.e. pointing to laravel-project/public from ~/www and ~/public_html. This way, updates to the project can be made easily using git pull to pull new changes in to the project directory, and there is no need to copy directories and move files around every time.

I am also thinking of adding some FAQs about 500/403 errors when deploying.

Thoughts?

@petehouston
Copy link
Owner

Sure, PRs are welcome :).

The more, the better.

@macguirerintoul
Copy link
Author

Hi @petehouston, I've updated the guide for Laravel 5.7 on my fork, and I have a suggestion for future Laravel updates. Would you like to create a branch on this repo called 5.7 (the latest version of Laravel), and set it as the default branch? This way, we can keep a history of guides for different versions of Laravel, create a new branch for each version of Laravel, and when people arrive at this repo, they automatically see the latest guide. Then, I can make a pull request from my 5.7 branch to yours. What do you think?

@petehouston
Copy link
Owner

@mrintoul can you make a PR? Thank you :)

@macguirerintoul
Copy link
Author

macguirerintoul commented Feb 8, 2019

I can make a PR into master if you like, but I was wondering what you thought of creating a branch for each version of Laravel to maintain guides for people who might not be using the latest version. If you think that's a good idea, you can either branch off from master after my PR, or you can create the 5.7 branch now and I can make a PR onto that one.

@nelson6e65
Copy link
Contributor

nelson6e65 commented Aug 15, 2019

Versioning instructions sounds nice, but... may not be easy to maintain. 😅

But yes, this needs update and old instructions should be moved to a legacy branch after deprecate instructions for old PHP/Laravel version instructions.

@macguirerintoul
Copy link
Author

may not be easy to maintain. 😅

Why not? We could just have a branch for each version and any changes would be pushed to that branch. I also imagine that when a new version is released, the previous version's branch would go untouched and we just continue working on the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants