Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case sensitive matcher and default favicon location. #26

Open
fluxsaas opened this issue Apr 7, 2013 · 0 comments
Open

case sensitive matcher and default favicon location. #26

fluxsaas opened this issue Apr 7, 2013 · 0 comments

Comments

@fluxsaas
Copy link

fluxsaas commented Apr 7, 2013

maybe you want to add a case-sensitive matchers for looking up the favicon:

 ['link[@rel="Shortcut Icon"]', lambda { |el| el.attr('href') }],

https://github.com/fluxsaas/pismo/blob/master/lib/pismo/internal_attributes.rb#L36

also, it might be nice to add the default favicon location e.g:

example.com/favicon.ico

seems to be widely used...

thanks for the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant