Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use attribute-based authorization and create single-hosted WopiValidator sample #192

Open
dviry opened this issue Mar 6, 2025 · 0 comments · May be fixed by #193
Open

Use attribute-based authorization and create single-hosted WopiValidator sample #192

dviry opened this issue Mar 6, 2025 · 0 comments · May be fixed by #193
Assignees
@dviry
Labels
refactoring

Comments

@dviry
Copy link
Collaborator

dviry commented Mar 6, 2025

  • I would like to create more "samples" for the WopiHost (different providers and integrations) and the WopiHost.Web (minimal Razor pages instead of bloated MVC) - what do you think? Maybe rename the existing ones to WopiHost.Samples.* and/or move to a new subfolder (I know when I started I was having difficulties understanding the difference/usage betwen WopiHost and WopiHost.Web)
    ->
  • I would like to replace all authorizationService.AuthorizeAsync() calls in the Controllers to an attribute-based authorization to reduce code bloat (IMO security should be implemented as Infrastructure when possible and not be "in the way") - would also be easier to unit test them

Originally posted by @dviry in #182
@dviry dviry self-assigned this Mar 6, 2025
dviry pushed a commit to dviry/WopiHost that referenced this issue Mar 6, 2025
petrsvihlik#192 use attribute-based authorization on controllers
c792420
dviry pushed a commit to dviry/WopiHost that referenced this issue Mar 6, 2025
petrsvihlik#192 create WopiValidator sample and move all to sample/
c7f7e4b
@dviry dviry linked a pull request Mar 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dviry dviry

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/192 attribute-based authnz and WOPI validator sample dviry/WopiHost
1 participant
@dviry