Feature/192 attribute-based authnz and WOPI validator sample #193
+90,443
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: note that the markdown links do not currently work since they are absolute references to your github repo - I could try using relative links (not sure if that would work) |
|
hmm CodeFactor is failing due to javascript libraries - can you exclude those? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 46.04% 46.25% +0.21%
==========================================
Files 50 48 -2
Lines 1101 1096 -5
Branches 114 111 -3
==========================================
Hits 507 507
+ Misses 555 548 -7
- Partials 39 41 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dviry It's gonna take me some time to go through all the changes. Looking at my calendar, I think I should be able to review it during the weekend. |
added 2 commits
March 6, 2025 17:48
…WopiHost into feature/192-authnz-sample
dviry
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
added 2 commits
March 6, 2025 17:49
dviry
requested a deployment
to
Integrate Pull Request
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #192
NOTE: IMO we should also rethink the authentication - as the custom scheme might not be needed in some integration (e.g. when running in Azure I already have a AAD Jwt token that I could simply re-use and would be way more secure) - but more on that on a separate ticket.